[10] RFR: 8186441: Change of behavior in the getMessage () method of the SOAPMessageContextImpl class
Hi, Can I, please, ask for assistance with reviewing the JDK-8186441 fix [1]? Problem description: In JDK9 we've fixed SAAJ bug in JDK: https://bugs.openjdk.java.net/browse/JDK-8159058 And this fix caused JDK-8186441 regression that resulted in breaking the namespace definitions in SOAP elements, i.e. the namespace definitions were added to SOAP body or to the parent elements. I'm aware that we're going to remove JAXWS and other EE modules in JDK10, but I still would like to fix this bug since it is a regression in existing code and JDK8 backport is also required for this issue. Will submit the same source fix to saaj-ri project [2] too. Solution: Fix the implementation of SaajStaxWriter::DeferredElement to add namespaces declaration to current element instead of parent. Webrev: http://cr.openjdk.java.net/~aefimov/8186441/10/00/index.html Testing: Modified regression test and XML/JAXWS JCK tests show no failures with the fix With Best Regards, Aleksei [1] https://bugs.openjdk.java.net/browse/JDK-8186441 [2] https://github.com/javaee/metro-saaj
Hi Aleks, The changes look reasonable Best Lance
On Nov 29, 2017, at 2:48 PM, Aleks Efimov <aleksej.efimov@oracle.com> wrote:
https://bugs.openjdk.java.net/browse/JDK-8159058 <https://bugs.openjdk.java.net/browse/JDK-8159058> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
Thank you Lance! Best, Aleksei On 11/29/2017 08:12 PM, Lance Andersen wrote:
Hi Aleks,
The changes look reasonable
Best Lance
On Nov 29, 2017, at 2:48 PM, Aleks Efimov <aleksej.efimov@oracle.com <mailto:aleksej.efimov@oracle.com>> wrote:
<http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 Lance.Andersen@oracle.com <mailto:Lance.Andersen@oracle.com>
participants (2)
-
Aleks Efimov
-
Lance Andersen