RFR: 8276338: Minor improve of wording for String.to(Lower|Upper)Case
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent. There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that. ------------- Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/6232/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6232&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276338 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/6232.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6232/head:pull/6232 PR: https://git.openjdk.java.net/jdk/pull/6232
On Wed, 3 Nov 2021 11:58:42 GMT, Pavel Rappo <prappo@openjdk.org> wrote:
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent.
There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that.
Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6232
On Wed, 3 Nov 2021 11:58:42 GMT, Pavel Rappo <prappo@openjdk.org> wrote:
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent.
There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that.
Marked as reviewed by naoto (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6232
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent.
There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that.
Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision: Fix inconsistent formatting - Removes stray whitespace character *inside* a sentence. - Makes sentences that introduce tables more similar. ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6232/files - new: https://git.openjdk.java.net/jdk/pull/6232/files/897ac5bb..625ae1aa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6232&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6232&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6232.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6232/head:pull/6232 PR: https://git.openjdk.java.net/jdk/pull/6232
On Thu, 4 Nov 2021 13:54:37 GMT, Pavel Rappo <prappo@openjdk.org> wrote:
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent.
There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that.
Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
Fix inconsistent formatting
- Removes stray whitespace character *inside* a sentence. - Makes sentences that introduce tables more similar.
Marked as reviewed by rriggs (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6232
On Wed, 3 Nov 2021 11:58:42 GMT, Pavel Rappo <prappo@openjdk.org> wrote:
This PR fixes two sentences which conflate a string with its length, and also makes the "equivalency wording" consistent.
There are many ways to fix "the resulting String may be a different length than the original String". The proposed way might be one of the most lightweight ways to do that.
This pull request has now been integrated. Changeset: bf4ddf9c Author: Pavel Rappo <prappo@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/bf4ddf9cb7408db321e7fd73600a5a9a85ca... Stats: 8 lines in 1 file changed: 0 ins; 1 del; 7 mod 8276338: Minor improve of wording for String.to(Lower|Upper)Case Reviewed-by: rriggs, naoto ------------- PR: https://git.openjdk.java.net/jdk/pull/6232
participants (3)
-
Naoto Sato
-
Pavel Rappo
-
Roger Riggs