JDK 9 RFR of 8042478: Include Mersenne primes in BigInteger primality testing
Hello, This follows from a prior discussion thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026771.html. Issue: https://bugs.openjdk.java.net/browse/JDK-8042478 Patch: http://cr.openjdk.java.net/~bpb/8042478/webrev.00/ Adds a test of the first 19 Mersenne primes. The remainder of the exponent list is commented out as it takes too long to run. The value 19 appears to give a reasonable execution time. The largest Mersenne prime tested is 285542542228902608580607. Thanks, Brian
On 05/08/2014 03:28 PM, Brian Burkhalter wrote:
Hello,
This follows from a prior discussion thread http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-May/026771.html.
Issue: https://bugs.openjdk.java.net/browse/JDK-8042478 Patch: http://cr.openjdk.java.net/~bpb/8042478/webrev.00/
Adds a test of the first 19 Mersenne primes. The remainder of the exponent list is commented out as it takes too long to run. The value 19 appears to give a reasonable execution time. The largest Mersenne prime tested is 285542542228902608580607.
Thanks,
Brian
Hi Brian, Generally looks good. However, I think it would be better structured if the array of Mersenne exponents was with the Mersenne testing method. Thanks, -Joe
Hi Joe, Moved the array of Mersenne exponents inside the Mersenne testing method: http://cr.openjdk.java.net/~bpb/8042478/webrev.01/ Thanks, Brian On May 8, 2014, at 3:42 PM, Joe Darcy <joe.darcy@oracle.com> wrote:
Hi Brian,
Generally looks good. However, I think it would be better structured if the array of Mersenne exponents was with the Mersenne testing method.
Thanks,
-Joe
Looks good Brian; thanks, -Joe On 05/08/2014 03:39 PM, Brian Burkhalter wrote:
Hi Joe,
Moved the array of Mersenne exponents inside the Mersenne testing method:
http://cr.openjdk.java.net/~bpb/8042478/webrev.01/ <http://cr.openjdk.java.net/%7Ebpb/8042478/webrev.01/>
Thanks,
Brian
On May 8, 2014, at 3:42 PM, Joe Darcy <joe.darcy@oracle.com> wrote:
Hi Brian,
Generally looks good. However, I think it would be better structured if the array of Mersenne exponents was with the Mersenne testing method.
Thanks,
-Joe
participants (2)
-
Brian Burkhalter
-
Joe Darcy