[9] Review request : JDK-8058728: TEST_BUG: Make java/lang/invoke/LFCaching/LFGarbageCollectedTest.java skip arrayElementSetter and arrayElementGetter methods
Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00 Thanks -Konstantin
Looks good. Best regards, Vladimir Ivanov On 9/19/14, 1:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00
Thanks
-Konstantin
On Sep 19, 2014, at 11:54 AM, Vladimir Ivanov <vladimir.x.ivanov@oracle.com> wrote:
Looks good.
Small typo in the comment: s/filed/field Otherwise +1, Paul.
Best regards, Vladimir Ivanov
On 9/19/14, 1:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00
Thanks
-Konstantin
mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev
Hi, looks good to me. how have you tested your changes? Thanks, Igor On 09/19/2014 01:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00
Thanks
-Konstantin
Yes, the test compiles and runs ok, but fails because of 8057020. If we remove -Djava.lang.invoke.MethodHandle.USE_LF_EDITOR=true, the test passes. -Konstantin On 19.09.2014 16:01, Igor Ignatyev wrote:
Hi,
looks good to me.
how have you tested your changes?
Thanks, Igor
On 09/19/2014 01:50 PM, Konstantin Shefov wrote:
Hello,
Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00
Thanks
-Konstantin
participants (4)
-
Igor Ignatyev
-
Konstantin Shefov
-
Paul Sandoz
-
Vladimir Ivanov