Request for Review(XS): 7156963 Incorrect copyright header in java/io/SerialCallbackContext
Please review. In addition to fixing the copyright I also fixed the incorrect indentation of the rest of the file (which is kind of hard to tell from the webrev). Bug: 7156963 CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963 Synopsis: Incorrect copyright header in java/io/SerialCallbackContext Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/ Testing: Verified that the JDK compiles properly. Thanks, Edvard
Looks fine, -Joe On 6/4/2012 7:01 AM, Edvard Wendelin wrote:
Please review. In addition to fixing the copyright I also fixed the incorrect indentation of the rest of the file (which is kind of hard to tell from the webrev).
Bug: 7156963
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963 Synopsis: Incorrect copyright header in java/io/SerialCallbackContext
Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/
Testing: Verified that the JDK compiles properly.
Thanks, Edvard
It seems the whole copyright header is one-char shifted to right. -Max On 06/05/2012 02:38 AM, Joe Darcy wrote:
Looks fine,
-Joe
On 6/4/2012 7:01 AM, Edvard Wendelin wrote:
Please review. In addition to fixing the copyright I also fixed the incorrect indentation of the rest of the file (which is kind of hard to tell from the webrev).
Bug: 7156963
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963 Synopsis: Incorrect copyright header in java/io/SerialCallbackContext
Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/
Testing: Verified that the JDK compiles properly.
Thanks, Edvard
Correct! Thanks for pointing that out. Don't know how it ended up getting one extra space on each line. Updated webrev on http://cr.openjdk.java.net/~ewendeli/7156963/webrev.02/ Thanks, Edvard On 06/05/2012 02:25 AM, Weijun Wang wrote:
It seems the whole copyright header is one-char shifted to right.
-Max
On 06/05/2012 02:38 AM, Joe Darcy wrote:
Looks fine,
-Joe
On 6/4/2012 7:01 AM, Edvard Wendelin wrote:
Please review. In addition to fixing the copyright I also fixed the incorrect indentation of the rest of the file (which is kind of hard to tell from the webrev).
Bug: 7156963
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7156963 Synopsis: Incorrect copyright header in java/io/SerialCallbackContext
Webrev: http://cr.openjdk.java.net/~ewendeli/7156963/webrev.01/
Testing: Verified that the JDK compiles properly.
Thanks, Edvard
participants (3)
-
Edvard Wendelin
-
Joe Darcy
-
Weijun Wang