make fails on a sed call on Mac OS X
Hi all, I just tried to build the guide and get: MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2 Anyone else experience this before I start digging in? Cheers, Martijn
Hi Martijn. I build on Mac (latest updates) and haven’t seen the issue. I’m not by the computer right now but can check what versions I have of sed etc later. /Jesper
26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg@gmail.com>:
Hi all,
I just tried to build the guide and get:
MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2
Anyone else experience this before I start digging in?
Cheers, Martijn
Jesper, Martijn, This looks like the issue that for sed on Linux, the `-i` option does not take an argument, whereas for sed on Mac, the `-i` option does take an argument, which is the suffix for a backup file. This difference can cause the following options to be misinterpreted. In this case, on Linux, the edit command will be "" and the first filename will be "/^ <meta charset=/d", giving the results that Martijn is observing. -- Jon On 5/26/20 11:50 AM, Jesper Wilhelmsson wrote:
Hi Martijn.
I build on Mac (latest updates) and haven’t seen the issue.
I’m not by the computer right now but can check what versions I have of sed etc later. /Jesper
26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg@gmail.com>:
Hi all,
I just tried to build the guide and get:
MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2
Anyone else experience this before I start digging in?
Cheers, Martijn
Thanks, Jesper, For the curious I'm using GNU sed 4.8 from HomeBrew: MININT-NSR6ILC:guide karianna$ which sed /usr/local/opt/gnu-sed/libexec/gnubin/sed MININT-NSR6ILC:guide karianna$ sed --version sed (GNU sed) 4.8 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later < https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. When I swap to the default sed on Mac OS X I do not get the error Cheers, Martijn On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson < jesper.wilhelmsson@oracle.com> wrote:
Hi Martijn.
I build on Mac (latest updates) and haven’t seen the issue.
I’m not by the computer right now but can check what versions I have of sed etc later. /Jesper
26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg@gmail.com>:
Hi all,
I just tried to build the guide and get:
MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2
Anyone else experience this before I start digging in?
Cheers, Martijn
My conclusion from Jon's answer is that we shouldn't use sed in the makefile. Would perl be a better option? I have sent a PR to replace sed with perl in the Makefile. /Jesper
On 26 May 2020, at 22:00, Martijn Verburg <martijnverburg@gmail.com> wrote:
Thanks, Jesper,
For the curious I'm using GNU sed 4.8 from HomeBrew:
MININT-NSR6ILC:guide karianna$ which sed /usr/local/opt/gnu-sed/libexec/gnubin/sed
MININT-NSR6ILC:guide karianna$ sed --version sed (GNU sed) 4.8 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html <https://gnu.org/licenses/gpl.html>>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.
When I swap to the default sed on Mac OS X I do not get the error
Cheers, Martijn
On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson <jesper.wilhelmsson@oracle.com <mailto:jesper.wilhelmsson@oracle.com>> wrote: Hi Martijn.
I build on Mac (latest updates) and haven’t seen the issue.
I’m not by the computer right now but can check what versions I have of sed etc later. /Jesper
26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg@gmail.com <mailto:martijnverburg@gmail.com>>:
Hi all,
I just tried to build the guide and get:
MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2
Anyone else experience this before I start digging in?
Cheers, Martijn
Sounds good to me. Cheers, Martijn On Tue, 26 May 2020 at 21:43, Jesper Wilhelmsson < jesper.wilhelmsson@oracle.com> wrote:
My conclusion from Jon's answer is that we shouldn't use sed in the makefile. Would perl be a better option? I have sent a PR to replace sed with perl in the Makefile. /Jesper
On 26 May 2020, at 22:00, Martijn Verburg <martijnverburg@gmail.com> wrote:
Thanks, Jesper,
For the curious I'm using GNU sed 4.8 from HomeBrew:
MININT-NSR6ILC:guide karianna$ which sed /usr/local/opt/gnu-sed/libexec/gnubin/sed
MININT-NSR6ILC:guide karianna$ sed --version sed (GNU sed) 4.8 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later < https://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.
When I swap to the default sed on Mac OS X I do not get the error
Cheers, Martijn
On Tue, 26 May 2020 at 19:52, Jesper Wilhelmsson < jesper.wilhelmsson@oracle.com> wrote:
Hi Martijn.
I build on Mac (latest updates) and haven’t seen the issue.
I’m not by the computer right now but can check what versions I have of sed etc later. /Jesper
26 maj 2020 kl. 20:34 skrev Martijn Verburg <martijnverburg@gmail.com>:
Hi all,
I just tried to build the guide and get:
MININT-NSR6ILC:guide karianna$ make pandoc src/changePlanning.md --css guidestyle.css --strip-comments --standalone --ascii --title-prefix "The OpenJDK Developers' Guide" | iconv -f UTF-8 -t ISO-8859-1 > build/changePlanning.html sed -i "" "/^ <meta charset=/d" build/changePlanning.html sed: can't read /^ <meta charset=/d: No such file or directory make: *** [build/changePlanning.html] Error 2
Anyone else experience this before I start digging in?
Cheers, Martijn
participants (3)
-
Jesper Wilhelmsson
-
Jonathan Gibbons
-
Martijn Verburg