September 2013 - hotspot-gc-dev

RFR(S) JDK-8025526: VirtualSpace should support per-instance disabling of large pages
by Mikael Gerdin 04 Oct '13

04 Oct '13

Hi, As part of ongoing work in getting Metaspace to properly enforce the MaxMetaspaceSize limit [JDK-8024547] we need to extend the VirtualSpace class to allow us to set the granularity at which VirtualSpace commits pages from the OS. Summary of changes: Extend VirtualSpace::initialize to take a parameter for setting the maximum commit granularity. The default value 0 keeps the previous behavior of using os::page_size_for_region to determine the granularity. Add unit tests for disabling and enabling large pages both at the ReservedSpace and the VirtualSpace level. Testing: JPRT run (includes running the new tests) Webrev: http://cr.openjdk.java.net/~mgerdin/8025526/webrev.0 Bug link: https://bugs.openjdk.java.net/browse/JDK-8025526 /Mikael

4 7

Request for review: 8016302: Change type of the number of GC workers to unsigned int (2)
by Vladimir Kempik 03 Oct '13

03 Oct '13

Hi all, Could I have a couple of reviews for this change? http://cr.openjdk.java.net/~vkempik/8016302/webrev.00/ In 7121618 variables representing GC workers (worker id, worker id offset) have been changed from int to unsigned int. Since then, code reintroduced the use of int's for this type of variable; fixing this by aligning the code to use uints for ints. Thanks, Vladimir

3 8

RFR: 8025313: MetaspaceMemoryPool incorrectly reports undefined size for max
by Erik Helin 02 Oct '13

02 Oct '13

Hi all, this patch fixes an issue where the metaspace memory pool reports -1 for MemoryPoolMXBean.getUsage().getMax(), even though the user has set MaxMetaspaceSize on the command line. The problem is that we in collectorPolicy.cpp use FLAG_SET_ERGO when aligning MaxMetaspaceSize while at the same time relying on FLAG_IS_CMDLINE in memoryPool.cpp when deciding what to return for MetaspacePool::calculate_max_size. This patch removes FLAG_SET_ERGO and instead simply sets MaxMetaspaceSize. Webrev: http://cr.openjdk.java.net/~ehelin/8025313/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8025313 Thanks, Erik

5 10

RFR: 8025226: TestPerfCountersAndMemoryPools.java fails with -Xmixed or -Xcomp
by Erik Helin 02 Oct '13

02 Oct '13

Hi all, this change fixes the test hotspot/test/gc/metaspace/TestPerfCountersAndMemoryPools.java which was broken when running with -Xcomp or -Xmixed. The problem was that the call to MemoryUsage.getUsed() triggered allocations of metadata. Since the performance counters are only updated at the end of a GC, this caused the performance counter and the memory pool for used metadata to differ in how much they reported. The solution is to only run the test in the interpreter by using -Xint. I also added the tag @library tag which was missing from the test. The test had never been run on "its own" before, the testlibrary had always been compiled by another test before the test was run. Finally, the test now only loops through the MemoryPoolMXBeans once to find the correct memory pool. Webrev: http://cr.openjdk.java.net/~ehelin/8025226/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8025226 Thanks, Erik

3 4

hg: hsx/hotspot-gc/hotspot: 8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads
by thomas.schatzl＠oracle.com 30 Sep '13

30 Sep '13

Changeset: 7ec10139bf37 Author: tschatzl Date: 2013-09-30 12:43 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7ec10139bf37 8025441: G1: assert "assert(thread < _num_vtimes) failed: just checking" fails when G1ConcRefinementThreads > ParallelGCThreads Summary: The initialization for the remembered set summary data structures used the wrong thread count, i.e. number of worker threads instead of number of refinement threads. Reviewed-by: brutisso ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.cpp ! src/share/vm/gc_implementation/g1/g1RemSetSummary.hpp + test/gc/g1/TestSummarizeRSetStatsThreads.java

1 0

RFR (XS): 8025605: G1: Heap expansion logging misleading for fully expanded heap
by Bengt Rutisson 30 Sep '13

30 Sep '13

Hi everyone, Could I have a couple of reviews for this small change? http://cr.openjdk.java.net/~brutisso/8025605/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8025605 Background: When running G1 with -XX:+PrintAdaptiveSizePolicy some information about the heap sizing is logged. When the heap is fully expanded but the ergonomics would have liked to expand even more the following message is logged: [G1Ergonomics (Heap Sizing) did not expand the heap, reason: heap expansion operation failed] It sounds like something failed, but in reality we just hit the -Xmx value. We should have a more informative message that does not look like a serious failure. With my suggested patch the message will instead be: [G1Ergonomics (Heap Sizing) did not expand the heap, reason: heap already fully expanded] Thanks, Bengt

3 6

hg: hsx/hotspot-gc/hotspot: 8025305: Cleanup CardTableModRefBS usage in G1
by mikael.gerdin＠oracle.com 27 Sep '13

27 Sep '13

Changeset: d55c004e1d4d Author: mgerdin Date: 2013-09-24 14:46 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/d55c004e1d4d 8025305: Cleanup CardTableModRefBS usage in G1 Summary: Move some G1 specific code from CardTableModRefBS to G1SATBCardTableModRefBS. Reviewed-by: brutisso, tschatzl, ehelin ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1CardCounts.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1EvacFailure.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/memory/cardTableModRefBS.cpp ! src/share/vm/memory/cardTableModRefBS.hpp

1 0

RFR (M) JDK-8025305 Cleanup CardTableModRefBS usage in G1
by Mikael Gerdin 27 Sep '13

27 Sep '13

Hi all! In preparation for fixing 8014555 (the bug discussed in the "G1 question: concurrent cleaning of dirty cards" thread) I'd like to clean up the CardTableModRefBS-code slightly. Summary of change: * Move some g1 specific functions from CardTableModRefBS to the G1 specific variant. I did not change the numeric CardValues. I'm afraid to change the last_reserved value since other GCs seem to depend on which bits are available below it. * Change the setup code for G1 to make sure that the BarrierSet is of the one G1 actually requires. * Remove the ModRefBarrierSet* from G1CollectedHeap (it's always the same as CollectedHeap::_barrier_set) * Add an accessor which performs a down-cast of CollectedHeap::_barrier_set to G1SATBCardTableModRefBS. * Modify G1 code which uses the *claimed or *deferred card values to use the type G1SATBCardTableModRefBS. * Remove the unused function CardTableModRefBS::claim_card (last usage was removed in "6923991: G1: improve scalability of RSet scanning" (rev 0414c1049f15) Webrev: http://cr.openjdk.java.net/~mgerdin/8025305/webrev.0/ Bug link: https://bugs.openjdk.java.net/browse/JDK-8025305 /Mikael

4 6

hg: hsx/hotspot-gc/hotspot: 35 new changesets
by thomas.schatzl＠oracle.com 27 Sep '13

27 Sep '13

Changeset: 63147986a428 Author: dcubed Date: 2013-09-18 07:02 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/63147986a428 8019835: Strings interned in different threads equal but does not == Summary: Add -XX:+VerifyStringTableAtExit option and code to verify StringTable invariants. Reviewed-by: rdurbin, sspitsyn, coleenp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp Changeset: dfae98867ee8 Author: dholmes Date: 2013-09-18 20:08 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/dfae98867ee8 8024826: (s) : Remove alt-rt.jar, used by +AggressiveOps Reviewed-by: alanb, chegar, dholmes, ksrini Contributed-by: Mike Duigou <mike.duigou(a)oracle.com> ! src/share/vm/runtime/arguments.cpp Changeset: c1d7040a1183 Author: sgabdura Date: 2013-09-18 16:48 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/c1d7040a1183 8022836: JVM crashes in JVMTIENVBASE::GET_CURRENT_CONTENDED_MONITOR and GET_OWNED_MONITOR Summary: Check that the _java_thread parameter is valid when it is possible that the JavaThread has exited after the initial checks were made in generated/jvmtifiles/jvmtiEnter.cpp: jvmti_GetCurrentContendedMonitor() Reviewed-by: dcubed, dsamersoff ! src/share/vm/prims/jvmtiEnvBase.hpp Changeset: 8c84f04ff977 Author: kevinw Date: 2013-09-18 19:50 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/8c84f04ff977 Merge Changeset: 6eb908998b32 Author: kevinw Date: 2013-09-19 08:47 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/6eb908998b32 Merge Changeset: 9ed97b511b26 Author: hseigel Date: 2013-09-19 11:04 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/9ed97b511b26 8024517: runtime/CDSCompressedKPtrs/XShareAuto.java failed with RuntimeException Summary: Make sure CDS is off by default when running server compiler. Reviewed-by: dholmes, coleenp ! src/share/vm/runtime/arguments.cpp ! test/runtime/CDSCompressedKPtrs/XShareAuto.java Changeset: 4f9a42c33738 Author: coleenp Date: 2013-09-20 09:30 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/4f9a42c33738 8022887: Assertion hit while using class and redefining it with RedefineClasses simultaneously Summary: Need to refetch each method from InstanceKlass after all safepoints. Removed leaky PreviousVersionInfo code. Reviewed-by: dcubed, sspitsyn ! src/share/vm/memory/metaspaceShared.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/handles.hpp ! src/share/vm/runtime/handles.inline.hpp Changeset: f201713502e0 Author: coleenp Date: 2013-09-20 09:44 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/f201713502e0 Merge Changeset: 1b03bed31241 Author: allwin Date: 2013-09-17 17:16 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/1b03bed31241 7196151: ParserTest SEGv on solaris Reviewed-by: sla, coleenp, ctornqvi, dsamersoff ! src/share/vm/services/diagnosticArgument.cpp Changeset: e5a25e4ae509 Author: mgerdin Date: 2013-09-20 10:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/e5a25e4ae509 Merge Changeset: 7c29904fdfa2 Author: coleenp Date: 2013-09-20 18:34 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/7c29904fdfa2 8014956: nashorn/api/javaaccess/MethodAccessTest.java test fails on sparc-solaris 64 Summary: reference_map[] array had uninitialized junk that was causing a bogus bootstrap method to be found. Reviewed-by: hseigel, dcubed, sspitsyn ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: df03413ad1a9 Author: coleenp Date: 2013-09-21 01:45 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/df03413ad1a9 Merge Changeset: 0f37d1badced Author: dcubed Date: 2013-09-20 12:58 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/0f37d1badced Merge ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: a7609ec351d6 Author: dcubed Date: 2013-09-20 18:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/a7609ec351d6 Merge ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp - test/gc/metaspace/ClassMetaspaceSizeInJmapHeap.java Changeset: 8ddc26f62476 Author: sla Date: 2013-09-22 06:31 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/8ddc26f62476 6989981: jstack causes "fatal error: ExceptionMark destructor expects no pending exceptions" Reviewed-by: sla, dsamersoff Contributed-by: Yasumasa Suenaga <yasu(a)ysfactory.dip.jp> ! src/share/vm/services/attachListener.cpp Changeset: 1f42d3ec1759 Author: dsamersoff Date: 2013-09-22 18:49 +0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/1f42d3ec1759 7133122: SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not Summary: replace PT_LOAD segment with library segment when necessary Reviewed-by: dholmes, sla ! agent/src/os/linux/ps_core.c Changeset: ae2edb3df7fb Author: dsamersoff Date: 2013-09-22 18:07 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/ae2edb3df7fb Merge Changeset: 084b21cd0228 Author: iklam Date: 2013-09-23 08:56 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/084b21cd0228 8025088: Missing cases for JVM_CONSTANT_MethodHandleInError cause crash if debugger steps into error-tagged method handle Summary: Need to refetch each method from InstanceKlass after all safepoints. Removed leaky PreviousVersionInfo code. Reviewed-by: coleenp, sspitsyn ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/constantPool.hpp Changeset: e8a0010ba69e Author: zgu Date: 2013-09-25 13:03 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/e8a0010ba69e Merge Changeset: 461159cd7a91 Author: tschatzl Date: 2013-09-26 12:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/461159cd7a91 Merge ! src/share/vm/classfile/symbolTable.cpp Changeset: 891687731b59 Author: anoll Date: 2013-09-24 15:56 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/891687731b59 7009641: Don't fail VM when CodeCache is full Summary: Allocation in the code cache returns NULL instead of failing the entire VM Reviewed-by: kvn, iveresov ! src/cpu/sparc/vm/vtableStubs_sparc.cpp ! src/cpu/x86/vm/vtableStubs_x86_32.cpp ! src/cpu/x86/vm/vtableStubs_x86_64.cpp ! src/share/vm/code/compiledIC.cpp ! src/share/vm/code/compiledIC.hpp ! src/share/vm/code/vtableStubs.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 1b64d46620a3 Author: kvn Date: 2013-09-24 16:08 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/1b64d46620a3 8022585: VM crashes when ran with -XX:+PrintInlining Summary: use adr_at() to access inline info structures in growableArray. Add ability to specify print inlining per method. Reviewed-by: twisti ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/library_call.cpp + test/compiler/print/PrintInlining.java Changeset: f637d4dc21bb Author: adlertz Date: 2013-09-26 08:48 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/f637d4dc21bb Merge Changeset: 586fa1919a89 Author: bpittore Date: 2013-09-20 15:06 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/586fa1919a89 8014911: Should use SUPPORTS_NATIVE_CX8 define to help C/C++ compiler elide blocks of code Summary: If SUPPORTS_NATIVE_CX8 true then supports_cx8() function hard coded to return 'true' Reviewed-by: kvn, twisti, dholmes ! src/share/vm/runtime/vm_version.hpp Changeset: 504d8f519adf Author: jiangli Date: 2013-09-20 20:19 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/504d8f519adf Merge Changeset: d682c6e24fe3 Author: bdelsart Date: 2013-09-26 01:30 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/d682c6e24fe3 Merge Changeset: 60a2d625db36 Author: bdelsart Date: 2013-09-26 04:00 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/60a2d625db36 Merge Changeset: 3da9fad1391e Author: tschatzl Date: 2013-09-26 06:34 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/3da9fad1391e Merge Changeset: c81dd5393a5e Author: tbell Date: 2013-09-25 12:23 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/c81dd5393a5e 8025411: JPRT to switch to the new Win platforms for JDK8 builds this week Reviewed-by: ksrini, katleman ! make/jprt.properties Changeset: fff4842215d1 Author: cl Date: 2013-09-26 10:43 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/fff4842215d1 Added tag jdk8-b109 for changeset c81dd5393a5e ! .hgtags Changeset: 58043478c26d Author: amurillo Date: 2013-09-26 13:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/58043478c26d Merge Changeset: 6209b0ed51c0 Author: amurillo Date: 2013-09-26 13:33 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/6209b0ed51c0 Added tag hs25-b52 for changeset 58043478c26d ! .hgtags Changeset: 24250c363d7f Author: amurillo Date: 2013-09-26 13:41 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/24250c363d7f 8025536: new hotspot build - hs25-b53 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 4fa18058548e Author: tschatzl Date: 2013-09-27 11:18 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/4fa18058548e Merge Changeset: ccef6e165e8b Author: tschatzl Date: 2013-09-27 13:41 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/ccef6e165e8b Merge

1 0

hg: hsx/hotspot-gc/hotspot: 8025279: metaspace/flags/maxMetaspaceSize throws OOM: out of Compressed Klass space
by mikael.gerdin＠oracle.com 27 Sep '13

27 Sep '13

Changeset: bc918fd1e584 Author: mgerdin Date: 2013-09-27 10:23 +0200 URL: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot/rev/bc918fd1e584 8025279: metaspace/flags/maxMetaspaceSize throws OOM: out of Compressed Klass space Summary: Only put "Compressed class space" as OOM cause if actually using Compressed class space Reviewed-by: jwilhelm, stefank, ehelin, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp

1 0