RFR (S) 8245478: Implementation: JEP 379: Shenandoah: A Low-Pause-Time Garbage Collector (Production)
Hi, JEP: https://openjdk.java.net/jeps/379 Impl: https://bugs.openjdk.java.net/browse/JDK-8245478 CSR: https://bugs.openjdk.java.net/browse/JDK-8245479 Webrev: https://cr.openjdk.java.net/~shade/8245478/webrev.01/ Along with flag changes, I also enabled back the tests that assume Shenandoah is "product", like we have in sh/jdk11 and sh/jdk8 trees. Testing: hotspot_gc_shenandoah -- Thanks, -Aleksey
Looks good to me! Thanks, Roman On Wed, 2020-05-27 at 11:30 +0200, Aleksey Shipilev wrote:
Hi,
JEP: https://openjdk.java.net/jeps/379 Impl: https://bugs.openjdk.java.net/browse/JDK-8245478 CSR: https://bugs.openjdk.java.net/browse/JDK-8245479
Webrev: https://cr.openjdk.java.net/~shade/8245478/webrev.01/
Along with flag changes, I also enabled back the tests that assume Shenandoah is "product", like we have in sh/jdk11 and sh/jdk8 trees.
Testing: hotspot_gc_shenandoah
Looks good to me too. Thanks, -Zhengyu On 5/27/20 7:21 AM, Roman Kennke wrote:
Looks good to me!
Thanks, Roman
On Wed, 2020-05-27 at 11:30 +0200, Aleksey Shipilev wrote:
Hi,
JEP: https://openjdk.java.net/jeps/379 Impl: https://bugs.openjdk.java.net/browse/JDK-8245478 CSR: https://bugs.openjdk.java.net/browse/JDK-8245479
Webrev: https://cr.openjdk.java.net/~shade/8245478/webrev.01/
Along with flag changes, I also enabled back the tests that assume Shenandoah is "product", like we have in sh/jdk11 and sh/jdk8 trees.
Testing: hotspot_gc_shenandoah
Thanks! Pushed. On 5/28/20 6:14 PM, Zhengyu Gu wrote:
Looks good to me too.
Thanks,
On 5/27/20 7:21 AM, Roman Kennke wrote:
Looks good to me!
On Wed, 2020-05-27 at 11:30 +0200, Aleksey Shipilev wrote:
JEP: https://openjdk.java.net/jeps/379 Impl: https://bugs.openjdk.java.net/browse/JDK-8245478 CSR: https://bugs.openjdk.java.net/browse/JDK-8245479
Webrev: https://cr.openjdk.java.net/~shade/8245478/webrev.01/
-- -Aleksey
Hello Aleksey, That looks good to me. However, I notice that you haven't changed the man page for java.1 . Will you be adding "-XX:UseShenandoahGC" and other options to it? BR, Stuart On 27/05/2020 10:30, Aleksey Shipilev wrote:
Hi,
JEP: https://openjdk.java.net/jeps/379 Impl: https://bugs.openjdk.java.net/browse/JDK-8245478 CSR: https://bugs.openjdk.java.net/browse/JDK-8245479
Webrev: https://cr.openjdk.java.net/~shade/8245478/webrev.01/
Along with flag changes, I also enabled back the tests that assume Shenandoah is "product", like we have in sh/jdk11 and sh/jdk8 trees.
Testing: hotspot_gc_shenandoah
On 5/27/20 10:53 PM, Stuart Monteith wrote:
That looks good to me.
Thanks!
However, I notice that you haven't changed the man page for java.1 . Will you be adding "-XX:UseShenandoahGC" and other options to it?
That needs to be handled separately: https://bugs.openjdk.java.net/browse/JDK-8246037 I notice that ZGC block was added rather obscurely by confidential "8227602: Update nroff version of man pages": https://hg.openjdk.java.net/jdk/jdk/rev/340d73f42b3c Not even sure there is a CSR for that change, and it feels like the change like that for Shenandoah would require additional CSR. -- Thanks, -Aleksey
participants (4)
-
Aleksey Shipilev
-
Roman Kennke
-
Stuart Monteith
-
Zhengyu Gu