RFR (S): 8213142: Use RAII to set the scanning source in G1ScanEvacuatedObjClosure
Hi all, in the review for JDK-8212911 Kim suggested to use RAII to set the _scanning_in_young field of the G1ScanEvacuatedObjClosure class. This also allows making sure that the field is actually initialized when used. This is the implementation for this idea. CR: https://bugs.openjdk.java.net/browse/JDK-8213142 Webrev: http://cr.openjdk.java.net/~tschatzl/8213142/webrev/ Testing: local gc jtreg run Thanks, Thomas
Hi Thomas, On 10/30/18 3:42 AM, Thomas Schatzl wrote:
Hi all,
in the review for JDK-8212911 Kim suggested to use RAII to set the _scanning_in_young field of the G1ScanEvacuatedObjClosure class. This also allows making sure that the field is actually initialized when used.
This is the implementation for this idea.
CR: https://bugs.openjdk.java.net/browse/JDK-8213142 Webrev: http://cr.openjdk.java.net/~tschatzl/8213142/webrev/ Looks good to me.
Thanks, Sangheon
Testing: local gc jtreg run
Thanks, Thomas
Hi Sangheon, Kim, On Tue, 2018-10-30 at 14:39 -0700, sangheon.kim@oracle.com wrote:
Hi Thomas,
On 10/30/18 3:42 AM, Thomas Schatzl wrote:
Hi all,
in the review for JDK-8212911 Kim suggested to use RAII to set the _scanning_in_young field of the G1ScanEvacuatedObjClosure class. This also allows making sure that the field is actually initialized when used.
This is the implementation for this idea.
CR: https://bugs.openjdk.java.net/browse/JDK-8213142 Webrev: http://cr.openjdk.java.net/~tschatzl/8213142/webrev/
Looks good to me.
thanks for your reviews - you might have noticed the change has already been pushed last week. Thomas
On Oct 30, 2018, at 6:42 AM, Thomas Schatzl <thomas.schatzl@oracle.com> wrote:
Hi all,
in the review for JDK-8212911 Kim suggested to use RAII to set the _scanning_in_young field of the G1ScanEvacuatedObjClosure class. This also allows making sure that the field is actually initialized when used.
This is the implementation for this idea.
CR: https://bugs.openjdk.java.net/browse/JDK-8213142 Webrev: http://cr.openjdk.java.net/~tschatzl/8213142/webrev/ Testing: local gc jtreg run
Thanks, Thomas
Looks good.
participants (3)
-
Kim Barrett
-
sangheon.kim@oracle.com
-
Thomas Schatzl