RFR: 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs
Hi all, can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801. Fix some merge error in this hunk:
From https://github.com/openjdk/jdk/commit/3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk
@@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) { + if (!use_adaptive_young_list_length()) { + _young_list_fixed_length = _young_gen_sizer->min_desired_young_length(); + } _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here! Did not revert cleanly. Everything else is unchanged. Testing: local compilation. tier1-tier3 running ------------- Commit messages: - Revert "8249676: [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs" Changes: https://git.openjdk.java.net/jdk/pull/281/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=281&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253411 Stats: 412 lines in 3 files changed: 79 ins; 207 del; 126 mod Patch: https://git.openjdk.java.net/jdk/pull/281.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/281/head:pull/281 PR: https://git.openjdk.java.net/jdk/pull/281
On Mon, 21 Sep 2020 09:40:26 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801.
Fix some merge error in this hunk:
From https://github.com/openjdk/jdk/commit/3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk @@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
+ if (!use_adaptive_young_list_length()) { + _young_list_fixed_length = _young_gen_sizer->min_desired_young_length(); + } _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!
Did not revert cleanly. Everything else is unchanged.
Testing: local compilation. tier1-tier3 running
Looks like a good backout. Disappointing... ------------- Marked as reviewed by kbarrett (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/281
Hi, On 21.09.20 12:03, Kim Barrett wrote:
On Mon, 21 Sep 2020 09:40:26 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801.
Fix some merge error in this hunk:
From https://github.com/openjdk/jdk/commit/3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk @@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
+ if (!use_adaptive_young_list_length()) { + _young_list_fixed_length = _young_gen_sizer->min_desired_young_length(); + } _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!
Did not revert cleanly. Everything else is unchanged.
Testing: local compilation. tier1-tier3 running
Looks like a good backout. Disappointing...
-------------
Marked as reviewed by kbarrett (Reviewer).
thanks for your and Stefan's reviews. I will integrate as soon as testing comes back clean if nobody objects. Thanks, Thomas
On Mon, 21 Sep 2020 09:40:26 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801.
Fix some merge error in this hunk:
From https://github.com/openjdk/jdk/commit/3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk @@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
+ if (!use_adaptive_young_list_length()) { + _young_list_fixed_length = _young_gen_sizer->min_desired_young_length(); + } _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!
Did not revert cleanly. Everything else is unchanged.
Testing: local compilation. tier1-tier3 running
Looks good. ------------- Marked as reviewed by sjohanss (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/281
On Mon, 21 Sep 2020 09:40:26 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
can I have some reviews for this change that reverts commit fa30241ddbbe953b61526bc3c44784198acdd801.
Fix some merge error in this hunk:
From https://github.com/openjdk/jdk/commit/3570f5a9, 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length , the method "max_expandable_regions()" has been changed to "max_regions()" so the first use of it in the hunk @@ -108,11 +107,14 @@ void G1Policy::init(G1CollectedHeap* g1h, G1CollectionSet* collection_set) {
+ if (!use_adaptive_young_list_length()) { + _young_list_fixed_length = _young_gen_sizer->min_desired_young_length(); + } _young_gen_sizer->adjust_max_new_size(_g1h->max_regions()); // <------------- here!
Did not revert cleanly. Everything else is unchanged.
Testing: local compilation. tier1-tier3 running
This pull request has now been integrated. Changeset: bba948f0 Author: Thomas Schatzl <tschatzl@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/bba948f0 Stats: 409 lines in 3 files changed: 204 ins; 76 del; 129 mod 8253411: [BACKOUT] [REDO] G1 incorrectly limiting young gen size when using the reserve can result in repeated full gcs Reviewed-by: kbarrett, sjohanss ------------- PR: https://git.openjdk.java.net/jdk/pull/281
participants (4)
-
Kim Barrett
-
Stefan Johansson
-
Thomas Schatzl
-
Thomas Schatzl