RFR (S): 8144663: Invalid constraints in memset_with_concurrent_readers_sparc.cpp inline assembly
Please review this change which fixes the constraints used in the inline assembly snippets in memset_with_concurrent_readers_sparc.cpp. Bug: https://bugs.openjdk.java.net/browse/JDK-8144663 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8144663/webrev.00/webrev/ The bug has more information, but in short the "+" needs to be the first character in the constraints string, and when used the corresponding constraint needs to be listed in the output constraints. I also took the liberty of clarifying one of the comments a bit, hopefully it's now ever so slightly more clear that the registers listed in the output constraints, while indeed being outputs, are only used as temporaries/are overwritten. Finally, I fixed a couple of comparisons of unsigned vs signed types - BytesPerWord is "unfortunately" signed. Tested using the -XX:+ExecuteInternalVMTests tests. Cheers, Mikael
On Dec 3, 2015, at 7:08 PM, Mikael Vidstedt <mikael.vidstedt@oracle.com> wrote:
Please review this change which fixes the constraints used in the inline assembly snippets in memset_with_concurrent_readers_sparc.cpp.
Bug: https://bugs.openjdk.java.net/browse/JDK-8144663 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8144663/webrev.00/webrev/
Looks good. And my apologies for getting the syntax wrong in the first place.
On 2015-12-03 16:15, Kim Barrett wrote:
On Dec 3, 2015, at 7:08 PM, Mikael Vidstedt <mikael.vidstedt@oracle.com> wrote:
Please review this change which fixes the constraints used in the inline assembly snippets in memset_with_concurrent_readers_sparc.cpp.
Bug: https://bugs.openjdk.java.net/browse/JDK-8144663 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8144663/webrev.00/webrev/
Looks good. And my apologies for getting the syntax wrong in the first place.
Thanks for the review, and for making testing it a breeze with the unit test in -XX:+ExecuteInternalVMTests! Cheers, Mikael
participants (2)
-
Kim Barrett
-
Mikael Vidstedt