On Mon, 21 Sep 2020 11:06:45 GMT, Stefan Karlsson <stefank@openjdk.org> wrote:

Rename ZGC's platform dependent code.

Changes requested by pliden (Reviewer). src/hotspot/os/posix/gc/z/zInitialize_posix.cpp line 27:

25: #include "gc/z/zInitialize.hpp" 26: 27: void ZInitialize::os_initialize() {

Shouldn't this be pd_initialize? src/hotspot/os/posix/gc/z/zVirtualMemory_posix.cpp line 32:

30: #include <sys/types.h> 31: 32: void ZVirtualMemoryManager::os_initialize() {

Same here. src/hotspot/os/windows/gc/z/zInitialize_windows.cpp line 28:

26: #include "gc/z/zSyscall_windows.hpp" 27: 28: void ZInitialize::os_initialize() {

And here. src/hotspot/os/windows/gc/z/zVirtualMemory_windows.cpp line 90:

88: } 89: 90: void ZVirtualMemoryManager::os_initialize() {

And here. src/hotspot/share/gc/z/zInitialize.cpp line 55:

53: ZBarrierSet::set_barrier_set(barrier_set); 54: 55: os_initialize();

And here. src/hotspot/share/gc/z/zInitialize.hpp line 33:

31: class ZInitialize { 32: private: 33: void os_initialize();

And here. src/hotspot/share/gc/z/zVirtualMemory.cpp line 52:

50: 51: // Initialize OS specific parts 52: os_initialize();

And here. src/hotspot/share/gc/z/zVirtualMemory.hpp line 54:

52: 53: // OS specific implementation 54: void os_initialize();

And here. ------------- PR: https://git.openjdk.java.net/jdk/pull/283

ZGC uses the suffixes _platform and _os to denote platform dependent code. It's more common to name these functions with a pd_ prefix. I suggest that we do the same in ZGC.

Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Review 1 ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/283/files - new: https://git.openjdk.java.net/jdk/pull/283/files/ec3fbf28..b3745a3b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=283&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=283&range=00-01 Stats: 22 lines in 8 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.java.net/jdk/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/283/head:pull/283 PR: https://git.openjdk.java.net/jdk/pull/283

ZGC uses the suffixes _platform and _os to denote platform dependent code. It's more common to name these functions with a pd_ prefix. I suggest that we do the same in ZGC.

Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Review 1 - 8253418: ZGC: Use pd_ prefix to denote platform dependent code ------------- Changes: https://git.openjdk.java.net/jdk/pull/283/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=283&range=02 Stats: 32 lines in 18 files changed: 0 ins; 0 del; 32 mod Patch: https://git.openjdk.java.net/jdk/pull/283.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/283/head:pull/283 PR: https://git.openjdk.java.net/jdk/pull/283

On Mon, 21 Sep 2020 11:06:45 GMT, Stefan Karlsson <stefank@openjdk.org> wrote:

ZGC uses the suffixes _platform and _os to denote platform dependent code. It's more common to name these functions with a pd_ prefix. I suggest that we do the same in ZGC.

This pull request has now been integrated. Changeset: 5a7390b6 Author: Stefan Karlsson <stefank@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/5a7390b6 Stats: 32 lines in 18 files changed: 0 ins; 0 del; 32 mod 8253418: ZGC: Use pd_ prefix to denote platform dependent code Reviewed-by: pliden, eosterlund ------------- PR: https://git.openjdk.java.net/jdk/pull/283