RFR: 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation
Changed to consider only gc pause times within the long time interval. Testing: Tier 1 ------------- Commit messages: - 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times Changes: https://git.openjdk.java.net/jdk/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253232 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/210/head:pull/210 PR: https://git.openjdk.java.net/jdk/pull/210
On Wed, 16 Sep 2020 18:23:45 GMT, Ivan Walulya <iwalulya@openjdk.org> wrote:
Changed to consider only gc pause times within the long time interval. Testing: Tier 1
Lgtm. Ship it. ------------- Marked as reviewed by tschatzl (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/210
On Wed, 16 Sep 2020 19:17:21 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Lgtm. Ship it.
Thanks Thomas! ------------- PR: https://git.openjdk.java.net/jdk/pull/210
On Sep 16, 2020, at 2:30 PM, Ivan Walulya <iwalulya@openjdk.java.net> wrote:
Changed to consider only gc pause times within the long time interval. Testing: Tier 1
-------------
Commit messages: - 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times
Changes: https://git.openjdk.java.net/jdk/pull/210/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=210&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8253232 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/210.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/210/head:pull/210
Looks good. /reviewer add kimbarrett
On Wed, 16 Sep 2020 18:23:45 GMT, Ivan Walulya <iwalulya@openjdk.org> wrote:
Changed to consider only gc pause times within the long time interval. Testing: Tier 1
Marked as reviewed by kbarrett (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/210
On Thu, 17 Sep 2020 04:42:30 GMT, Kim Barrett <kbarrett@openjdk.org> wrote:
Changed to consider only gc pause times within the long time interval. Testing: Tier 1
Marked as reviewed by kbarrett (Reviewer).
Thanks Kim ------------- PR: https://git.openjdk.java.net/jdk/pull/210
On Wed, 16 Sep 2020 18:23:45 GMT, Ivan Walulya <iwalulya@openjdk.org> wrote:
Changed to consider only gc pause times within the long time interval. Testing: Tier 1
This pull request has now been integrated. Changeset: 4ac69349 Author: Ivan Walulya <iwalulya@openjdk.org> Committer: Thomas Schatzl <tschatzl@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/4ac69349 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8253232: G1Analytics::compute_pause_time_ratios() uses wrong pause times in calculation Reviewed-by: tschatzl, kbarrett ------------- PR: https://git.openjdk.java.net/jdk/pull/210
participants (4)
-
Ivan Walulya
-
Kim Barrett
-
Kim Barrett
-
Thomas Schatzl