January 2022 - hotspot-jfr-dev

[jdk18] RFR: 8278628: jdk/jfr/jmx/streaming/TestMaxSize.java Expected only one or two chunks
by Erik Gahlin 18 Jan '22

18 Jan '22

Hi, Could I have review of a test fix. The test expects at most two chunks in the file repository. While it is true that RemoteRecordingStream::setMaxSize(1_000_000) will make sure there are not more than two known chunks, there can potentially be three files, which is what the test looks for. A file has to be completed before it becomes known to setMaxSize. Testing: jdk/jfr/jmx/streaming/TestMaxSize Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk18/pull/105/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=105&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8278628 Stats: 26 lines in 1 file changed: 14 ins; 6 del; 6 mod Patch: https://git.openjdk.java.net/jdk18/pull/105.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/105/head:pull/105 PR: https://git.openjdk.java.net/jdk18/pull/105

2 2

[jdk18] RFR: 8256291: RunThese30M fails "assert(_class_unload ? true : ((((JfrTraceIdBits::load(class_loader_klass)) & ((1 << 4) << 8)) != 0))) failed: invariant"
by Markus Grönlund 18 Jan '22

18 Jan '22

Greetings, Please help review this changeset to rectify the incomplete tagging of ClassLoaderData (CLDs). Tagging is incomplete for CLDs that represent initiating class loaders or are yet to load classes but participating in the ClassLoaderStatistics event. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - deep tag for cld Changes: https://git.openjdk.java.net/jdk18/pull/103/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=103&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8256291 Stats: 9 lines in 1 file changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk18/pull/103.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/103/head:pull/103 PR: https://git.openjdk.java.net/jdk18/pull/103

2 2

RFR: 8279797: JFR: Show .jfc options in JFR.start help
by Erik Gahlin 15 Jan '22

15 Jan '22

Hi, Could I have review of an enhancement that shows available .jfc options in the help text for JFR.start. I also fixed a typo. I choose to return an empty string if the default.jfc or profile.jfc can't be parsed. This could potentially happen if a user modifies files in JAVA_HOME/lib/jfr. An alternative would be to return an error message in the help text, but I think it would be hard for users to understand. Likely they think the text describes the command somehow. When they use JFR.start, they will get a parse failure, and it's much more easier to understand that point. This PR has a conflict with https://github.com/openjdk/jdk/pull/7066, so "new JFCModel(s, l -> {});" might need to be changed to "JFCModel.create(s, l -> {});" before checking in. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Add logging - Initial Changes: https://git.openjdk.java.net/jdk/pull/7073/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7073&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279797 Stats: 28 lines in 1 file changed: 25 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jdk/pull/7073.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7073/head:pull/7073 PR: https://git.openjdk.java.net/jdk/pull/7073

2 4

RFR: 8279918: Fix various doc typos
by Pavel Rappo 14 Jan '22

14 Jan '22

- Most of the typos are of a trivial kind: missing whitespace. - If any of the typos should be fixed in the upstream projects instead, please say so; I will drop those typos from the patch. - As I understand it, in ImageInputStream and DataInput is an irrelevant formatting artefact and thus can be removed. - ' is an apostrophe, which does not require to be encoded. ------------- Commit messages: - Initial commit Changes: https://git.openjdk.java.net/jdk/pull/7063/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7063&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279918 Stats: 85 lines in 34 files changed: 0 ins; 0 del; 85 mod Patch: https://git.openjdk.java.net/jdk/pull/7063.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7063/head:pull/7063 PR: https://git.openjdk.java.net/jdk/pull/7063

10 27

RFR: 8279825: JFR: JFCModel should use SecuritySupport for predefined .jfc files
by Erik Gahlin 14 Jan '22

14 Jan '22

Hi, Could I have review of a fix that allows the new parser, used by JFCModel, to read known configuration files in JAVA_HOME/lib/jfr without FilePermission, similar to the older parser. Testing: jdk/jdkjfr Thanks Erik ------------- Commit messages: - Merge branch 'openjdk:master' into smstart - Remove whitespace - Initial Changes: https://git.openjdk.java.net/jdk/pull/7066/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7066&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279825 Stats: 53 lines in 4 files changed: 31 ins; 13 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/7066.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7066/head:pull/7066 PR: https://git.openjdk.java.net/jdk/pull/7066

2 2

RFR: 8259774: Deprecate -XX:FlightRecorderOptions:samplethreads
by Erik Gahlin 13 Jan '22

13 Jan '22

Hi, Could I have a review of a removal of command line option that hasn't worked for the last five years. ' JDK 17 introduced .jfc options which allows the sampler to be disabled without a dedicated command line flag in native. Testing: jdk/jdk/jfr + tier1 + tier2 Thanks Erik ------------- Commit messages: - Update TestJcmdConfigure.java - Update man page - Initial Changes: https://git.openjdk.java.net/jdk/pull/7018/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7018&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259774 Stats: 84 lines in 12 files changed: 7 ins; 73 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/7018.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7018/head:pull/7018 PR: https://git.openjdk.java.net/jdk/pull/7018

2 3

RFR: 8279821: JFR: Log warnings properly when loading a misconfigured .jfc file
by Erik Gahlin 12 Jan '22

12 Jan '22

Hi, Could I have a review of a fix that redirects a log warning from standard out to unified logging and dcmd output. For details, see bug. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/7024/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7024&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279821 Stats: 10 lines in 3 files changed: 1 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/jdk/pull/7024.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7024/head:pull/7024 PR: https://git.openjdk.java.net/jdk/pull/7024

2 2

RFR: 8279785 JFR: 'jfr configure' should show default values
by Erik Gahlin 11 Jan '22

11 Jan '22

Hi, Could I have a review of an enhancement that shows the default values for the 'jfr configure' command. For example, Options for default.jfc: gc=<off|normal|detailed|high|all> (normal) allocation-profiling=<off|low|medium|high|maximum> (low) compiler=<off|normal|detailed|all> (normal) method-profiling=<off|normal|high|max> (normal) thread-dump=<off|once|60s|10s|1s> (once) exceptions=<off|errors|all> (errors) memory-leaks=<off|types|stack-traces|gc-roots> (types) locking-threshold=<timespan> (20ms) file-threshold=<timespan> (20ms) socket-threshold=<timespan> (20ms) class-loading=<true|false> (false) Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Reverse public modifier - Initial Changes: https://git.openjdk.java.net/jdk/pull/7020/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7020&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279785 Stats: 18 lines in 3 files changed: 16 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7020.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7020/head:pull/7020 PR: https://git.openjdk.java.net/jdk/pull/7020

2 2

RFR: 8279682: JFR: Remove dead code
by Erik Gahlin 11 Jan '22

11 Jan '22

Hi, Could I have a review of removal of some code. I also made a class final, so unused fields are easier to spot. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/7006/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7006&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279682 Stats: 61 lines in 6 files changed: 0 ins; 59 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/7006.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/7006/head:pull/7006 PR: https://git.openjdk.java.net/jdk/pull/7006

2 2

RFR: 8279647: JFR: Unclosed directory stream
by Erik Gahlin 11 Jan '22

11 Jan '22

Hi, Could I have a review of a fix that closes the directory stream that is used when fetching the predefined .jfc files. I also added a sanity check so it is a file (not a directory). Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Check directory using SecuritySupport - Initial Changes: https://git.openjdk.java.net/jdk/pull/6999/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6999&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279647 Stats: 9 lines in 1 file changed: 0 ins; 3 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/6999.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6999/head:pull/6999 PR: https://git.openjdk.java.net/jdk/pull/6999

2 2