October 2022 - hotspot-jfr-dev

RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
by Markus Grönlund 04 Jun '24

04 Jun '24

Greetings, please help review this changeset. Details are listed in the the JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8276125 Changes: https://git.openjdk.java.net/jdk/pull/6702/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6702&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276125 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6702.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702 PR: https://git.openjdk.java.net/jdk/pull/6702

5 6

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]
by Markus Grönlund 28 Feb '23

28 Feb '23

> Greetings, > > [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to address artefact tagging for Compiler threads, letting threads run _thread_in_native to avoid the transition. Unfortunately, that attempt proved inadequate. > > The epoch race is avoided only by performing the transition to _thread_in_vm. > > Testing: jdk_jfr > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: delegate assertion ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8724/files - new: https://git.openjdk.java.net/jdk/pull/8724/files/9ce10130..b4e59b72 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8724.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8724/head:pull/8724 PR: https://git.openjdk.java.net/jdk/pull/8724

3 2

RFR: 8288783: JFR: Error messages are confusing when options conflict in -XX:StartFlightRecording
by Chihiro Ito 09 Feb '23

09 Feb '23

Could I have a review of PR that fixes incorrect error messages regarding of recording. The current message is very confusing. If a user types jcmd <pid> JFR.start name=abc name=def or java --XX:StartFlightRecording=name=abc,name=def, the error message says "Duplicates in diagnostic command arguments", but doesn't know what options are duplicated. Furthermore, if a user specifies two or three duplicate parameters, the same logs will be output. It should say follows, Option name can only be specified once with starting flight recording Options name and disk can only be specified once with starting flight recording Options name, disk and maxage can only be specified once with starting flight recording This problem affects --XX:StartFlightRecording, jcmd JFR.start, JFR.stop, JFR.dump, JFR.check, and MBean. For other than start, the output is as follows, (example of dump) Option name can only be specified once with dumping flight recording Testing: jdk/jdk/jfr Thanks Chihiro ------------- Commit messages: - modify whitespace from windows to linux - modify copyright - Modify log message and test case - JDK-8288783 Initial Changes: https://git.openjdk.org/jdk/pull/9302/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288783 Stats: 442 lines in 10 files changed: 431 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9302.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9302/head:pull/9302 PR: https://git.openjdk.org/jdk/pull/9302

5 16

RFR: 8295879: JFR: Remove warnings in the jdk.jfr module
by Erik Gahlin 26 Oct '22

26 Oct '22

Hi, Could I have a review of PR that removes some warnings in the jdk.jfr module. Testing: jdk/jdk/jfr + tier1 Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/10850/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10850&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295879 Stats: 69 lines in 21 files changed: 0 ins; 69 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10850.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10850/head:pull/10850 PR: https://git.openjdk.org/jdk/pull/10850

2 2

RFR: 8295863 JFR: Use expected size for Maps and Sets
by Erik Gahlin 26 Oct '22

26 Oct '22

Hi, Could I have a review of PR that uses HashMap.newHashMap and HashSet.newHashSet to set the expected size. I also increased the size where the number of events have increased since JDK 9. Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Adjustments - Initial Changes: https://git.openjdk.org/jdk/pull/10844/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10844&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295863 Stats: 31 lines in 14 files changed: 0 ins; 0 del; 31 mod Patch: https://git.openjdk.org/jdk/pull/10844.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10844/head:pull/10844 PR: https://git.openjdk.org/jdk/pull/10844

2 2

RFR: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
by Erik Gahlin 21 Oct '22

21 Oct '22

Hi, It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariables" and believe events have been removed from recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data. To help users, a warning message is now written if an event filter doesn't match metadata available in the recording. Thanks Erik ------------- Commit messages: - Remove file and imports - Initial Changes: https://git.openjdk.org/jdk/pull/10779/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295650 Stats: 70 lines in 3 files changed: 52 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/10779.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10779/head:pull/10779 PR: https://git.openjdk.org/jdk/pull/10779

2 4

Integrated: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events
by Joakim Nordström 19 Oct '22

19 Oct '22

On Wed, 25 May 2022 12:24:03 GMT, Joakim Nordström <jnordstrom(a)openjdk.org> wrote: > Changed the JFR chunk rotation lock object to specific internal class. This allows that specific Object.wait() event to be skipped, thus not adding JFR internal noise to recordings. > > # Testing > - jdk_jfr This pull request has now been integrated. Changeset: fc889577 Author: Joakim Nordström <jnordstrom(a)openjdk.org> Committer: Markus Grönlund <mgronlun(a)openjdk.org> URL: https://git.openjdk.org/jdk/commit/fc889577eaf3f564d896818c1d9b1eb6fa5a8758 Stats: 29 lines in 6 files changed: 20 ins; 3 del; 6 mod 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events Reviewed-by: dholmes, egahlin ------------- PR: https://git.openjdk.org/jdk/pull/8883

1 0

Re: RFR: 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events [v2]
by Joakim Nordström 19 Oct '22

19 Oct '22

> Changed the JFR chunk rotation lock object to specific internal class. This allows that specific Object.wait() event to be skipped, thus not adding JFR internal noise to recordings. > > # Testing > - jdk_jfr Joakim Nordström has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Changed name to CHUNK_ROTATION_MONITOR and made some other rearrangements - Changed name to CHUNK_ROTATION_MONITOR and made some other rearrangements - Merge branch 'master' into JDK-8286707-jfr-dont-commit-jfr-internal-jdk-javamonitorwait-events - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events - 8286707: JFR: Don't commit JFR internal jdk.JavaMonitorWait events ------------- Changes: - all: https://git.openjdk.org/jdk/pull/8883/files - new: https://git.openjdk.org/jdk/pull/8883/files/755d2359..a1a95ed9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=8883&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=8883&range=00-01 Stats: 507955 lines in 7712 files changed: 264969 ins; 180116 del; 62870 mod Patch: https://git.openjdk.org/jdk/pull/8883.diff Fetch: git fetch https://git.openjdk.org/jdk pull/8883/head:pull/8883 PR: https://git.openjdk.org/jdk/pull/8883

4 10

RFR: 8295419: JFR: Change name of jdk.JitRestart
by Erik Gahlin 18 Oct '22

18 Oct '22

Could I have a review of a change to the JFR event metadata. The convention used by JFR events have been to use uppercase for acronyms, for example CPULoad, TLSHandshake, SystemGC, JVMInformation and ObjectAllocationInNewTLAB. The jdk.JitRestart event should follow the same convention to be consistent (jdk.JITRestart). The event has not been in a release so there is no harm in changing. Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/10731/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10731&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295419 Stats: 7 lines in 6 files changed: 0 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/10731.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10731/head:pull/10731 PR: https://git.openjdk.org/jdk/pull/10731

2 4

RFR: 8292177: InitialSecurityProperty JFR event
by Sean Coffey 18 Oct '22

18 Oct '22

New JFR event to record state of initial security properties. Debug output is also now added for these properties via -Djava.security.debug=properties ------------- Commit messages: - merge with master - Correct test bug ids - fix up imports - Add security debug test logic - Add JFR testcase - remove mirror event - 8292177 initial commit Changes: https://git.openjdk.org/jdk/pull/10394/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10394&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292177 Stats: 200 lines in 11 files changed: 196 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/10394.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10394/head:pull/10394 PR: https://git.openjdk.org/jdk/pull/10394

6 39