November 2022 - hotspot-jfr-dev

RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
by Markus Grönlund 04 Jun '24

04 Jun '24

Greetings, please help review this changeset. Details are listed in the the JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8276125 Changes: https://git.openjdk.java.net/jdk/pull/6702/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6702&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276125 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6702.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702 PR: https://git.openjdk.java.net/jdk/pull/6702

5 6

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]
by Markus Grönlund 28 Feb '23

28 Feb '23

> Greetings, > > [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to address artefact tagging for Compiler threads, letting threads run _thread_in_native to avoid the transition. Unfortunately, that attempt proved inadequate. > > The epoch race is avoided only by performing the transition to _thread_in_vm. > > Testing: jdk_jfr > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: delegate assertion ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8724/files - new: https://git.openjdk.java.net/jdk/pull/8724/files/9ce10130..b4e59b72 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8724.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8724/head:pull/8724 PR: https://git.openjdk.java.net/jdk/pull/8724

3 2

RFR: 8288783: JFR: Error messages are confusing when options conflict in -XX:StartFlightRecording
by Chihiro Ito 09 Feb '23

09 Feb '23

Could I have a review of PR that fixes incorrect error messages regarding of recording. The current message is very confusing. If a user types jcmd <pid> JFR.start name=abc name=def or java --XX:StartFlightRecording=name=abc,name=def, the error message says "Duplicates in diagnostic command arguments", but doesn't know what options are duplicated. Furthermore, if a user specifies two or three duplicate parameters, the same logs will be output. It should say follows, Option name can only be specified once with starting flight recording Options name and disk can only be specified once with starting flight recording Options name, disk and maxage can only be specified once with starting flight recording This problem affects --XX:StartFlightRecording, jcmd JFR.start, JFR.stop, JFR.dump, JFR.check, and MBean. For other than start, the output is as follows, (example of dump) Option name can only be specified once with dumping flight recording Testing: jdk/jdk/jfr Thanks Chihiro ------------- Commit messages: - modify whitespace from windows to linux - modify copyright - Modify log message and test case - JDK-8288783 Initial Changes: https://git.openjdk.org/jdk/pull/9302/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288783 Stats: 442 lines in 10 files changed: 431 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9302.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9302/head:pull/9302 PR: https://git.openjdk.org/jdk/pull/9302

5 16

RFR: 8292266: Add JFR event for total Reference processing time
by Sangheon Kim 18 Jan '23

18 Jan '23

Hi all, Can I have reviews for this change that adds a new JFR event for total Reference Processing time? The goal is to generate a new JFR event if there is already measured time. This CR doesn't add new time measurement. Testing: hs-tier1 ~ 3 Thanks, Sangheon ------------- Commit messages: - Remove comment out code. - Combine GCTrace::report method. - Separate GCTrace::report method. Changes: https://git.openjdk.org/jdk/pull/11230/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11230&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292266 Stats: 141 lines in 11 files changed: 135 ins; 2 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11230.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11230/head:pull/11230 PR: https://git.openjdk.org/jdk/pull/11230

6 19

RFR: 8292265: Add old gen used field at G1HeapSummary JFR event.
by Sangheon Kim 09 Dec '22

09 Dec '22

Hi all, Can I have reviews for this change which adds 'old gen used' field at existing G1HeapSummary event? Testing: tier1 ~ tier3 Thanks, Sangheon ------------- Commit messages: - 8292265: Add old gen used field at G1HeapSummary JFR event Changes: https://git.openjdk.org/jdk/pull/11303/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11303&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292265 Stats: 10 lines in 4 files changed: 6 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11303.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11303/head:pull/11303 PR: https://git.openjdk.org/jdk/pull/11303

3 8

RFR: 8297402: jfr tool processes large padded integers incorrectly
by Ekaterina Vergizova 06 Dec '22

06 Dec '22

Could I have a review of a PR that fixes jfr tool reading of large padded integers. Some integer values are written to jfr recordings using write_padded_at_offset<u4>() method. Their size in recording is always 4 bytes. jfr tool reads all integer values by readInt() method, which doesn't take size into account. For padded values greater than (1 << 28), jfr tool tries to read 5 bytes from recording and fails. I suggest to fix reading of padded integers in jfr tool. If a value is written by write_padded_at_offset<u4>() then it should be read by readPaddedInt() method which doesn't read more than 4 bytes. (It can be less then 4 bytes due to JDK-8246260) Tested with jdk/jfr and tier1. jfr recording generated by TestHugeStackTracePool.java with jdk11 (attached to JDK-8297402) is successfully processed by jfr tool after the fix. ------------- Commit messages: - 8297402: jfr tool processes large padded integers incorrectly Changes: https://git.openjdk.org/jdk/pull/11289/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11289&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297402 Stats: 27 lines in 5 files changed: 20 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/11289.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11289/head:pull/11289 PR: https://git.openjdk.org/jdk/pull/11289

3 6

RFR: 8297608: JFR: Incorrect duration after chunk rotation
by Erik Gahlin 02 Dec '22

02 Dec '22

Could I have a review of PR that fixes a problem with the duration of instant events after a chunk rotation. Testing: test/jdk/dk/jdk/jfr Thanks Erik ------------- Commit messages: - Update comment - Update comment - Initial Changes: https://git.openjdk.org/jdk/pull/11364/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11364&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297608 Stats: 87 lines in 2 files changed: 78 ins; 5 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11364.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11364/head:pull/11364 PR: https://git.openjdk.org/jdk/pull/11364

2 2

RFR: JDK-8297215: Update libs tests to use @enablePreview
by Joe Darcy 01 Dec '22

01 Dec '22

Similar to an update recently done for langtools tests, update the libraries regression tests to take advantage of the @enablePreview jtreg feature. ------------- Commit messages: - JDK-8297215: Update libs tests to use @enablePreview Changes: https://git.openjdk.org/jdk/pull/11222/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297215 Stats: 122 lines in 36 files changed: 33 ins; 1 del; 88 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222

4 14

RFR: 8295350: JFR: Add stop methods for recording streams
by Erik Gahlin 01 Dec '22

01 Dec '22

Could I have a review of PR that adds stop() methods to RecordingStream and RemoteRecordingStream. Purpose is to provide better control of what is being recorded. Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Set stream end for parser barrier - Initial Changes: https://git.openjdk.org/jdk/pull/11337/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11337&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295350 Stats: 641 lines in 12 files changed: 636 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11337.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11337/head:pull/11337 PR: https://git.openjdk.org/jdk/pull/11337

4 8

Re: Snippets include in the jmod file
by Erik Gahlin 29 Nov '22

29 Nov '22

Correct, there is a discussion regarding this here. https://github.com/openjdk/jdk/pull/10982#discussion_r1032820405 Erik ________________________________ From: hotspot-jfr-dev <hotspot-jfr-dev-retn(a)openjdk.org> on behalf of Kasper Nielsen <kasperni(a)gmail.com> Sent: Tuesday, November 29, 2022 3:34 PM To: hotspot-jfr-dev(a)openjdk.org <hotspot-jfr-dev(a)openjdk.org> Subject: Snippets include in the jmod file Hi, When executing > jmod list jdk.jfr.jmod It looks like various snippets are included in the jmod file (Both 19 and 20-ea) classes/jdk/jfr/snippets/Snippets$CPU.class classes/jdk/jfr/snippets/Snippets$CPUEvent.class classes/jdk/jfr/snippets/Snippets$Example$HelloWorld.class classes/jdk/jfr/snippets/Snippets$Example.class classes/jdk/jfr/snippets/Snippets$ExampleServlet.class classes/jdk/jfr/snippets/Snippets$HTTPGetRequest.class classes/jdk/jfr/snippets/Snippets$HTTPPostRequest.class classes/jdk/jfr/snippets/Snippets$HTTPRequest.class classes/jdk/jfr/snippets/Snippets$HelloWorld.class classes/jdk/jfr/snippets/Snippets$HttpServlet.class classes/jdk/jfr/snippets/Snippets$HttpServletRequest.class classes/jdk/jfr/snippets/Snippets$HttpServletResponse.class classes/jdk/jfr/snippets/Snippets$OrderEvent.class classes/jdk/jfr/snippets/Snippets$OrderId.class classes/jdk/jfr/snippets/Snippets$OrderLineEvent.class classes/jdk/jfr/snippets/Snippets$RegExpControl.class classes/jdk/jfr/snippets/Snippets$Severity.class classes/jdk/jfr/snippets/Snippets$Temperature.class classes/jdk/jfr/snippets/Snippets$TransactionBlocked.class classes/jdk/jfr/snippets/Snippets$TransactionId.class classes/jdk/jfr/snippets/Snippets.class classes/jdk/jfr/snippets/consumer/Snippets$PackageOveriview.class classes/jdk/jfr/snippets/consumer/Snippets.class I'm assuming they should only be included in the Javadoc. Best, Kasper

1 0