November 2022 - hotspot-jfr-dev

Snippets include in the jmod file
by Kasper Nielsen 29 Nov '22

29 Nov '22

Hi, When executing > jmod list jdk.jfr.jmod It looks like various snippets are included in the jmod file (Both 19 and 20-ea) classes/jdk/jfr/snippets/Snippets$CPU.class classes/jdk/jfr/snippets/Snippets$CPUEvent.class classes/jdk/jfr/snippets/Snippets$Example$HelloWorld.class classes/jdk/jfr/snippets/Snippets$Example.class classes/jdk/jfr/snippets/Snippets$ExampleServlet.class classes/jdk/jfr/snippets/Snippets$HTTPGetRequest.class classes/jdk/jfr/snippets/Snippets$HTTPPostRequest.class classes/jdk/jfr/snippets/Snippets$HTTPRequest.class classes/jdk/jfr/snippets/Snippets$HelloWorld.class classes/jdk/jfr/snippets/Snippets$HttpServlet.class classes/jdk/jfr/snippets/Snippets$HttpServletRequest.class classes/jdk/jfr/snippets/Snippets$HttpServletResponse.class classes/jdk/jfr/snippets/Snippets$OrderEvent.class classes/jdk/jfr/snippets/Snippets$OrderId.class classes/jdk/jfr/snippets/Snippets$OrderLineEvent.class classes/jdk/jfr/snippets/Snippets$RegExpControl.class classes/jdk/jfr/snippets/Snippets$Severity.class classes/jdk/jfr/snippets/Snippets$Temperature.class classes/jdk/jfr/snippets/Snippets$TransactionBlocked.class classes/jdk/jfr/snippets/Snippets$TransactionId.class classes/jdk/jfr/snippets/Snippets.class classes/jdk/jfr/snippets/consumer/Snippets$PackageOveriview.class classes/jdk/jfr/snippets/consumer/Snippets.class I'm assuming they should only be included in the Javadoc. Best, Kasper

1 0

RFR: 8297570: jdk/jfr/threading/TestDeepVirtualStackTrace.java fails with -XX:-UseTLAB
by Aleksey Shipilev 28 Nov '22

28 Nov '22

This is the only test in `jdk_loom` that fails without `-XX:-UseTLAB`. The test specifically looks for `ObjectAllocationOutsideTLAB` event, and there are lots of those events with `-XX:-UseTLAB`. We can fix the test to look for the event we actually want. This depends on [JDK-8297491](https://bugs.openjdk.org/browse/JDK-8297491) that fixed Loom code to actually disable TLABs. Additional testing: - [x] Affected test with `-XX:+UseTLAB` and `-XX:-UseTLAB` ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/11352/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11352&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297570 Stats: 36 lines in 1 file changed: 20 ins; 2 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/11352.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11352/head:pull/11352 PR: https://git.openjdk.org/jdk/pull/11352

2 9

Integrated: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
by Severin Gehwolf 24 Nov '22

24 Nov '22

On Mon, 14 Nov 2022 20:19:29 GMT, Severin Gehwolf <sgehwolf(a)openjdk.org> wrote: > Please review this addition to the jdk.ContainerConfigration event which adds information > about the container host. Specifically, the total amount of memory of the host system. > > Testing: > - [x] New test case (passed, fails before) > - [x] JFR tests. Passed. > > Thoughts? This pull request has now been integrated. Changeset: 3c4d5204 Author: Severin Gehwolf <sgehwolf(a)openjdk.org> URL: https://git.openjdk.org/jdk/commit/3c4d5204ff96280b123f42a8cfbaef308e470b69 Stats: 48 lines in 7 files changed: 43 ins; 0 del; 5 mod 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory Reviewed-by: egahlin ------------- PR: https://git.openjdk.org/jdk/pull/11143

1 0

Re: RFR: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
by Erik Gahlin 23 Nov '22

23 Nov '22

On Mon, 14 Nov 2022 20:19:29 GMT, Severin Gehwolf <sgehwolf(a)openjdk.org> wrote: > Please review this addition to the jdk.ContainerConfigration event which adds information > about the container host. Specifically, the total amount of memory of the host system. > > Testing: > - [x] New test case (passed, fails before) > - [x] JFR tests. Passed. > > Thoughts? Marked as reviewed by egahlin (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/11143

2 1

RFR: 8297338: JFR: RemoteRecordingStream doesn't respekt setMaxAge and setMaxSize
by Erik Gahlin 23 Nov '22

23 Nov '22

Could I have a review of a PR that fixes so event data is kept in the disk repository if max age or max size have been set. This is similar implementation as RecordingStream: https://github.com/openjdk/jdk/blob/b366d17a94e5b16710fd915ef4cf04aaf911b45… Testing: 100 * test/jdk/jdk/jfr/jmx/stream/TestRemoteDump.java + 1 * test/jdk/jdk/jfr/ Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/11275/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11275&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297338 Stats: 93 lines in 2 files changed: 90 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/11275.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11275/head:pull/11275 PR: https://git.openjdk.org/jdk/pull/11275

2 5

RFR: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
by Ralf Schmelter 23 Nov '22

23 Nov '22

This fails for the same reason as in https://bugs.openjdk.org/browse/JDK-8293166 while testing the dump on crash feature of JFR. Disabling tiered compilation avoids triggering this error. ------------- Commit messages: - Disable tiered compilation to reduce spurious test failures on Linux ppc64 and aarch64 Changes: https://git.openjdk.org/jdk/pull/11203/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11203&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297142 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11203.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11203/head:pull/11203 PR: https://git.openjdk.org/jdk/pull/11203

2 2

Re: RFR: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
by Severin Gehwolf 23 Nov '22

23 Nov '22

On Mon, 14 Nov 2022 20:19:29 GMT, Severin Gehwolf <sgehwolf(a)openjdk.org> wrote: > Please review this addition to the jdk.ContainerConfigration event which adds information > about the container host. Specifically, the total amount of memory of the host system. > > Testing: > - [x] New test case (passed, fails before) > - [x] JFR tests. Passed. > > Thoughts? Ping? Anyone willing to review this? ------------- PR: https://git.openjdk.org/jdk/pull/11143

2 2

RFR: JDK-8297164: Update troff man pages and CheckManPageOptions.java
by Jonathan Gibbons 21 Nov '22

21 Nov '22

Please review an update for the troff man pages, following the recent update to upgrade to use pandoc 2.19.2 (See https://bugs.openjdk.org/browse/JDK-8297165) In conjunction with this, one javadoc test also needs to be updated, to work with the new form of output generated by the new version of pandoc. ------------- Commit messages: - JDK-8297164: Update troff man pages and CheckManPageOptions.java Changes: https://git.openjdk.org/jdk/pull/11223/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11223&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297164 Stats: 8944 lines in 29 files changed: 471 ins; 1589 del; 6884 mod Patch: https://git.openjdk.org/jdk/pull/11223.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11223/head:pull/11223 PR: https://git.openjdk.org/jdk/pull/11223

3 6

RFR: 8297245: JFR: TestRemoteDump should use RemoteRecordingStream
by Erik Gahlin 18 Nov '22

18 Nov '22

Could I have a review of a test fix. RecordingStream was being tested instead of RemoteRecordingStream. Testing: 100 times test/jdk/jdk/jfr/jmx/streamingTestRemoteDump Thanks Erik ------------- Commit messages: - Fix modifier order - initial Changes: https://git.openjdk.org/jdk/pull/11233/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11233&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297245 Stats: 10 lines in 1 file changed: 3 ins; 2 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/11233.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11233/head:pull/11233 PR: https://git.openjdk.org/jdk/pull/11233

2 2

RFR: 8297006: JFR: AbstractEventStream should not hold thread instance
by Erik Gahlin 16 Nov '22

16 Nov '22

Could I have a review of a PR that removes an unnecessary reference to a thread. This could potentially become a memory leak. Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/11166/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11166&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297006 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/11166.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11166/head:pull/11166 PR: https://git.openjdk.org/jdk/pull/11166

2 2