September 2022 - hotspot-jfr-dev

RFR: 8291022: JFR: Reduce logging in ChunkHeader constructor
by Erik Gahlin 30 Sep '22

30 Sep '22

Could I have review of change that removes some unnecessary and unreliable logging. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Remove traling whitepace - Initial Changes: https://git.openjdk.org/jdk/pull/9640/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9640&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291022 Stats: 16 lines in 1 file changed: 6 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/9640.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9640/head:pull/9640 PR: https://git.openjdk.org/jdk/pull/9640

2 2

RFR: 8291021: JFR: Only one finished state in ChunkHeader class
by Erik Gahlin 30 Sep '22

30 Sep '22

Could I have a review of PR that removes the field isFinished in the ChunkHeader class. It's sufficient with the finished field. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/9639/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9639&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291021 Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/9639.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9639/head:pull/9639 PR: https://git.openjdk.org/jdk/pull/9639

2 2

RFR: 8254711: Add java.security.Provider.getService JFR Event
by Sean Coffey 22 Sep '22

22 Sep '22

Add a JFR Event for `java.security.Provider.getService(String type, String algorithm)` calls. ------------- Commit messages: - Track successful getInstance calls only - Merge branch 'master' into 8254711-jfr-jca - Refactor and use of static Event on - Merge branch 'master' into 8254711-jfr-jca - new test - Event iteration - Merge branch 'master' into 8254711-jfr-jca - JFR edits Changes: https://git.openjdk.org/jdk/pull/9657/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9657&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8254711 Stats: 305 lines in 8 files changed: 269 ins; 27 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9657.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9657/head:pull/9657 PR: https://git.openjdk.org/jdk/pull/9657

5 18

RFR: 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening
by Paul Hohensee 20 Sep '22

20 Sep '22

Trivial change to get a test to run reliably on Shenandoah and ZGC. ------------- Commit messages: - 8293828: JFR: jfr/event/oldobject/TestClassLoaderLeak.java still fails when GC cycles are not happening Changes: https://git.openjdk.org/jdk/pull/10319/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10319&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293828 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10319.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10319/head:pull/10319 PR: https://git.openjdk.org/jdk/pull/10319

2 4

RFR: 8244681: Add a warning for possibly lossy conversion in compound assignments
by Adam Sotona 15 Sep '22

15 Sep '22

Please review this patch adding new lint option, **lossy-conversions**, to javac to warn about type casts in compound assignments with possible lossy conversions. The new lint warning is shown if the type of the right-hand operand of a compound assignment is not assignment compatible with the type of the variable. The implementation of the warning is based on similar check performed to emit "possible lossy conversion" compilation error for simple assignments. Proposed patch also include complex matrix-style test with positive and negative test cases of lossy conversions in compound assignments. Proposed patch also disables this new lint option in all affected JDK modules and libraries to allow smooth JDK build. Individual cases to address possibly lossy conversions warnings in JDK are already addressed in a separate umbrella issue and its sub-tasks. Thanks for your review, Adam ------------- Commit messages: - Merge branch 'openjdk:master' into JDK-8244681 - 8244681: Add a warning for possibly lossy conversion in compound assignments - 8244681: Add a warning for possibly lossy conversion in compound assignments Changes: https://git.openjdk.java.net/jdk/pull/8599/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8599&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8244681 Stats: 449 lines in 26 files changed: 444 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jdk/pull/8599.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8599/head:pull/8599 PR: https://git.openjdk.java.net/jdk/pull/8599

9 31

RFR: 8291753: Add JFR event for GC CPU Time
by Sangheon Kim 08 Sep '22

08 Sep '22

Hi all, Could I have reviews to add new JFR event for GC CPU time? Currently only log message is available for CPU time (user, system, real). As there is already GCTraceCPUTime class which is used for a log message, I added GCTracer to deliver the event. The log message of CPU time is printed after GC is completed and tried to keep same. For G1, manually checked there is not difference. For test, I had to add an exception as GCCpuTime will be generated after GC end. Testing: tier 1 ~ 3 Thanks, Sangheon ------------- Commit messages: - Split G1FullGCMark - Add JFR event of GCCpuTime. Changes: https://git.openjdk.org/jdk/pull/9760/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9760&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8291753 Stats: 181 lines in 20 files changed: 136 ins; 11 del; 34 mod Patch: https://git.openjdk.org/jdk/pull/9760.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9760/head:pull/9760 PR: https://git.openjdk.org/jdk/pull/9760

4 16

RFR: 8293403: JfrResolution::on_jvmci_resolution crashes when caller is null
by Doug Simon 06 Sep '22

06 Sep '22

When the `caller` argument to `JfrResolution::on_jvmci_resolution` is null, the method should raise an `IllegalAccessError` instead of crashing with a SIGSEGV. ------------- Commit messages: - handle nullptr for caller argument in JfrResolution::on_jvmci_resolution Changes: https://git.openjdk.org/jdk/pull/10180/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10180&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293403 Stats: 10 lines in 2 files changed: 8 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10180.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10180/head:pull/10180 PR: https://git.openjdk.org/jdk/pull/10180

2 2

Integrated: 8293355: JDK-8293167 included bad copyright header
by Magnus Ihse Bursie 05 Sep '22

05 Sep '22

This breaks CI testing in Oracle. ------------- Commit messages: - 8293355: JDK-8293167 included bad copyright header Changes: https://git.openjdk.org/jdk/pull/10162/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10162&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293355 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/10162.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10162/head:pull/10162 PR: https://git.openjdk.org/jdk/pull/10162

2 2

RFR: 8293167: Memory leak in JfrThreadSampler if stackdepth is larger than default (64)
by Markus Grönlund 05 Sep '22

05 Sep '22

Greetings, please help review this fix that address a memory leak in the JfrThreadSampler when using a stackdepth larger than default (64). Please see the JIRA issue for details. Testing: jdk_jfr, stress Thanks Markus ------------- Commit messages: - 8293167 Changes: https://git.openjdk.org/jdk/pull/10129/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10129&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293167 Stats: 63 lines in 6 files changed: 33 ins; 3 del; 27 mod Patch: https://git.openjdk.org/jdk/pull/10129.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10129/head:pull/10129 PR: https://git.openjdk.org/jdk/pull/10129

2 5