January 2023 - hotspot-jfr-dev

RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
by Markus Grönlund 04 Jun '24

04 Jun '24

Greetings, please help review this changeset. Details are listed in the the JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8276125 Changes: https://git.openjdk.java.net/jdk/pull/6702/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6702&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276125 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6702.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702 PR: https://git.openjdk.java.net/jdk/pull/6702

5 6

RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/
by Johan Sjölen 10 May '23

10 May '23

Do the conversion in the share/jfr/ sub-directory and all of its files. ------------- Commit messages: - More manual fixes - Merge remote-tracking branch 'origin/master' into JDK-8300245 - Manual fixes - Replace NULL with nullptr in share/jfr/ Changes: https://git.openjdk.org/jdk/pull/12034/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12034&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300245 Stats: 2079 lines in 126 files changed: 0 ins; 0 del; 2079 mod Patch: https://git.openjdk.org/jdk/pull/12034.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12034/head:pull/12034 PR: https://git.openjdk.org/jdk/pull/12034

3 20

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v8]
by Justin King 09 Mar '23

09 Mar '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with one additional commit since the last revision: Update comment Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/428520cc..f6996e1a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=06-07 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

3 7

Re: RFR: 8280844: Epoch shift synchronization point for Compiler threads is inadequate [v2]
by Markus Grönlund 28 Feb '23

28 Feb '23

> Greetings, > > [JDK-8233111](https://bugs.openjdk.java.net/browse/JDK-8233111) attempted to address artefact tagging for Compiler threads, letting threads run _thread_in_native to avoid the transition. Unfortunately, that attempt proved inadequate. > > The epoch race is avoided only by performing the transition to _thread_in_vm. > > Testing: jdk_jfr > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: delegate assertion ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/8724/files - new: https://git.openjdk.java.net/jdk/pull/8724/files/9ce10130..b4e59b72 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8724&range=00-01 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8724.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8724/head:pull/8724 PR: https://git.openjdk.java.net/jdk/pull/8724

3 2

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v13]
by Justin King 17 Feb '23

17 Feb '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with one additional commit since the last revision: Fix copyright Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/139c4205..f2ea0038 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=12 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=11-12 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

3 15

RFR: 8288783: JFR: Error messages are confusing when options conflict in -XX:StartFlightRecording
by Chihiro Ito 09 Feb '23

09 Feb '23

Could I have a review of PR that fixes incorrect error messages regarding of recording. The current message is very confusing. If a user types jcmd <pid> JFR.start name=abc name=def or java --XX:StartFlightRecording=name=abc,name=def, the error message says "Duplicates in diagnostic command arguments", but doesn't know what options are duplicated. Furthermore, if a user specifies two or three duplicate parameters, the same logs will be output. It should say follows, Option name can only be specified once with starting flight recording Options name and disk can only be specified once with starting flight recording Options name, disk and maxage can only be specified once with starting flight recording This problem affects --XX:StartFlightRecording, jcmd JFR.start, JFR.stop, JFR.dump, JFR.check, and MBean. For other than start, the output is as follows, (example of dump) Option name can only be specified once with dumping flight recording Testing: jdk/jdk/jfr Thanks Chihiro ------------- Commit messages: - modify whitespace from windows to linux - modify copyright - Modify log message and test case - JDK-8288783 Initial Changes: https://git.openjdk.org/jdk/pull/9302/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9302&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8288783 Stats: 442 lines in 10 files changed: 431 ins; 2 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/9302.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9302/head:pull/9302 PR: https://git.openjdk.org/jdk/pull/9302

5 16

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v12]
by Justin King 31 Jan '23

31 Jan '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with four additional commits since the last revision: - Update copyright Signed-off-by: Justin King <jcking(a)google.com> - Add missing include Signed-off-by: Justin King <jcking(a)google.com> - Remove unused include Signed-off-by: Justin King <jcking(a)google.com> - Reorganize tests Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/d43b9f10..139c4205 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=10-11 Stats: 254 lines in 3 files changed: 152 ins; 102 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

2 2

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v11]
by Justin King 27 Jan '23

27 Jan '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with one additional commit since the last revision: Fix test Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/3b9decfa..d43b9f10 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=09-10 Stats: 34 lines in 1 file changed: 0 ins; 5 del; 29 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

2 2

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v10]
by Justin King 25 Jan '23

25 Jan '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision: - Merge remote-tracking branch 'upstream/master' into byteswap - Be restrict on requiring 1, 2, 4, or 8 byte integers Signed-off-by: Justin King <jcking(a)google.com> - Consolidate more byteswap implementations and upgrade bit reversal Signed-off-by: Justin King <jcking(a)google.com> - Update comment Signed-off-by: Justin King <jcking(a)google.com> - Add missing static_cast to XL C/C++ implementation Signed-off-by: Justin King <jcking(a)google.com> - Cleanup Bytes::swap_uN Signed-off-by: Justin King <jcking(a)google.com> - Add XL C/C++ builtins Signed-off-by: Justin King <jcking(a)google.com> - Fix mistake in MSVC implementation Signed-off-by: Justin King <jcking(a)google.com> - Update comment to reflect previous commit change Signed-off-by: Justin King <jcking(a)google.com> - Use __bulitin_bswap for GCC in debug builds Signed-off-by: Justin King <jcking(a)google.com> - ... and 6 more: https://git.openjdk.org/jdk/compare/051995b8...3b9decfa ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/56e5c235..3b9decfa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=08-09 Stats: 22873 lines in 944 files changed: 9818 ins; 3924 del; 9131 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

1 0

Re: RFR: JDK-8300783: Consolidate byteswap implementations [v9]
by Justin King 25 Jan '23

25 Jan '23

> Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078. Justin King has updated the pull request incrementally with one additional commit since the last revision: Consolidate more byteswap implementations and upgrade bit reversal Signed-off-by: Justin King <jcking(a)google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/f6996e1a..56e5c235 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=07-08 Stats: 196 lines in 3 files changed: 97 ins; 25 del; 74 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114

1 0