June 2023 - hotspot-jfr-dev

[jdk21] RFR: 8309959: JFR: Display N/A for missing data amount
by Frederic Thevenet 26 Jun '23

26 Jun '23

Hi! This pull request contains a backport of commit [9872a141](https://github.com/openjdk/jdk/commit/9872a14192ce3964b934c19ab68… from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Erik Gahlin on 14 Jun 2023 and was reviewed by Markus Grönlund and Thomas Stuefe. This is a follow-up to [JDK-8309550](https://github.com/openjdk/jdk17u-dev/pull/1438) which was integrated *before* RDP1, so backporting this one also as a matter of consistency. Thanks! ------------- Commit messages: - Backport 9872a14192ce3964b934c19ab685342ffd396986 Changes: https://git.openjdk.org/jdk21/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=56&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309959 Stats: 14 lines in 2 files changed: 6 ins; 2 del; 6 mod Patch: https://git.openjdk.org/jdk21/pull/56.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/56/head:pull/56 PR: https://git.openjdk.org/jdk21/pull/56

2 5

RFR: 8310561: JFR: Unify decodeDescriptors(String, String)
by Erik Gahlin 22 Jun '23

22 Jun '23

Could I have a review of a fix that removes duplicated code. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14598/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14598&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310561 Stats: 53 lines in 2 files changed: 0 ins; 49 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/14598.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14598/head:pull/14598 PR: https://git.openjdk.org/jdk/pull/14598

2 2

[jdk21] RFR: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
by Erik Gahlin 22 Jun '23

22 Jun '23

8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent ------------- Commit messages: - Backport 658c3374d88836f5c8745f777e836d502f0ec2ca Changes: https://git.openjdk.org/jdk21/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=54&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309296 Stats: 38 lines in 1 file changed: 21 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk21/pull/54.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/54/head:pull/54 PR: https://git.openjdk.org/jdk21/pull/54

2 2

RFR: 8310512: Cleanup indentation in jfc files
by Christoph Langer 21 Jun '23

21 Jun '23

Trivial whitespace cleanup in JFR jfc files. ------------- Commit messages: - JDK-8310512 Changes: https://git.openjdk.org/jdk/pull/14579/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14579&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310512 Stats: 30 lines in 2 files changed: 0 ins; 4 del; 26 mod Patch: https://git.openjdk.org/jdk/pull/14579.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14579/head:pull/14579 PR: https://git.openjdk.org/jdk/pull/14579

2 3

RFR: 8310335 JFR: Modernize collections and switch statements
by Erik Gahlin 21 Jun '23

21 Jun '23

Could I have a review of an update to the jfr modules to use more recent APIs and language constructs. Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14547/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14547&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310335 Stats: 256 lines in 92 files changed: 0 ins; 25 del; 231 mod Patch: https://git.openjdk.org/jdk/pull/14547.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14547/head:pull/14547 PR: https://git.openjdk.org/jdk/pull/14547

3 6

RFR: 8309296: jdk/jfr/event/runtime/TestAgentEvent.java fails due to "missing" dynamic JavaAgent
by Erik Gahlin 21 Jun '23

21 Jun '23

Could I have a review of a test fix. Problem is that events use another clock source than Recording::getStartTime(). I added -XX:+UnlockExperimentalVMOptions -XX:-UseFastUnorderedTimeStamps in case the Attach thread and the Main thread executes on different cores and there could be drift. The flags may, or may not, also fix the time source issue. Regardless, I think it's prudent to do time comparison against an event, not the recording timestamps, because they are different things conceptually and there are tweaks to the recording timestamps (to make them work well with Instant.now(), not the event clock source) Testing: jdk/jdk/jfr/event/runtime/TestAgentEvent.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14572/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14572&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8309296 Stats: 38 lines in 1 file changed: 21 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/14572.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14572/head:pull/14572 PR: https://git.openjdk.org/jdk/pull/14572

2 2

RFR: 8304478: Initial nroff manpage generation for JDK 22
by David Holmes 19 Jun '23

19 Jun '23

Updated the version to 22-ea and year to 2024. The following unpublished changes will also be included in this update: - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage contains a special character - [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update jarsigner man page after [JDK-8303410](https://bugs.openjdk.org/browse/JDK-8303410) - [JDK-8301207](https://bugs.openjdk.org/browse/JDK-8301207): (jdeps) Deprecate jdeps -profile option The following changes were never applied to the closed sources and are "lost" by this update. These changes will need to be re-applied directly in JDK 21 and JDK 22: - [JDK-8296656](https://bugs.openjdk.org/browse/JDK-8296656): java.lang.NoClassDefFoundError exception on running fully legitimate code - [JDK-8015831](https://bugs.openjdk.org/browse/JDK-8015831): Add lint check for calling overridable methods from a constructor Thanks. ------------- Commit messages: - 8304478: Initial nroff manpage generation for JDK 22 Changes: https://git.openjdk.org/jdk/pull/14462/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14462&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304478 Stats: 140 lines in 28 files changed: 1 ins; 105 del; 34 mod Patch: https://git.openjdk.org/jdk/pull/14462.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14462/head:pull/14462 PR: https://git.openjdk.org/jdk/pull/14462

6 14

RFR: 8310266 JFR: Refactor after 'view' command
by Erik Gahlin 19 Jun '23

19 Jun '23

8310266 JFR: Refactor after 'view' command ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14532/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14532&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310266 Stats: 1925 lines in 56 files changed: 827 ins; 951 del; 147 mod Patch: https://git.openjdk.org/jdk/pull/14532.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14532/head:pull/14532 PR: https://git.openjdk.org/jdk/pull/14532

2 2

RFR: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
by Erik Gahlin 19 Jun '23

19 Jun '23

8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object" ------------- Commit messages: - Backport 7d4b77ad9ee803d89eab5632f5c65ac843a68b3c Changes: https://git.openjdk.org/jdk21/pull/32/files Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=32&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304835 Stats: 21 lines in 1 file changed: 9 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk21/pull/32.diff Fetch: git fetch https://git.openjdk.org/jdk21.git pull/32/head:pull/32 PR: https://git.openjdk.org/jdk21/pull/32

2 2

RFR: 8304835 jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
by Erik Gahlin 19 Jun '23

19 Jun '23

Could I have a review of a test fix? The test fails intermittently because it's hard to guarantee that an object is being sampled. Fix is to repeat until one is found. Testing: jdk/jdk/event/oldObject/TestArrayInformation.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14467/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14467&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304835 Stats: 21 lines in 1 file changed: 9 ins; 2 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/14467.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14467/head:pull/14467 PR: https://git.openjdk.org/jdk/pull/14467

3 7