January 2024 - hotspot-jfr-dev

RFR: 8310994: Add JFR event for selection operations
by Tim Prinzing 25 Jun '24

25 Jun '24

Added mirror event with static methods: jdk.internal.event.SelectionEvent that provides the duration of select calls and the count of how many keys are available. Emit the event from SelectorImpl::lockAndDoSelect Test at jdk.jfr.event.io.TestSelectionEvents ------------- Commit messages: - remove trailing whitespace - event logic outside of the lock, selector in try block - remove unused import - fix TestConfigure failure - add event defaults - Merge branch 'master' into JDK-8310994 - minor test cleanup - Merge branch 'master' into JDK-8310994 - 8310994: Add JFR event for selection operations Changes: https://git.openjdk.org/jdk/pull/16710/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16710&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310994 Stats: 265 lines in 9 files changed: 264 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16710.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16710/head:pull/16710 PR: https://git.openjdk.org/jdk/pull/16710

6 40

RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
by Markus Grönlund 04 Jun '24

04 Jun '24

Greetings, please help review this changeset. Details are listed in the the JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8276125 Changes: https://git.openjdk.java.net/jdk/pull/6702/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6702&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276125 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6702.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702 PR: https://git.openjdk.java.net/jdk/pull/6702

5 6

RFR: 8294978: Convert 5 test/jdk/jdk/jfr tests from ASM library to Classfile API
by Chen Liang 03 May '24

03 May '24

Converted these tests to Classfile API and some of the constants to Constant API. InstrumentationCallback.callback wasn't changed to a record since I cannot figure out how to ship a nested record class with InstrumentationCallback in a jar. ------------- Commit messages: - Convert jdk.jfr tests to ASM Changes: https://git.openjdk.org/jdk/pull/13072/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13072&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294978 Stats: 283 lines in 5 files changed: 75 ins; 108 del; 100 mod Patch: https://git.openjdk.org/jdk/pull/13072.diff Fetch: git fetch https://git.openjdk.org/jdk pull/13072/head:pull/13072 PR: https://git.openjdk.org/jdk/pull/13072

3 19

RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
by Taizo Kurashige 27 Feb '24

27 Feb '24

Hi, I fixed the typos for JFR.start and JFR.dump. Acconding to issue's description, there is some typo in JFR.stop documentation, but I couldn't find that. I confirmed that there is no such typo in this repository. So I thought there was no need to fix JFR.stop documentation. I confirmed that the fixes are reflected and that all of the jdk_jfr tests pass. Could someone please review it? ------------- Commit messages: - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Changes: https://git.openjdk.org/jdk/pull/16413/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16413&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313710 Stats: 114 lines in 3 files changed: 0 ins; 0 del; 114 mod Patch: https://git.openjdk.org/jdk/pull/16413.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16413/head:pull/16413 PR: https://git.openjdk.org/jdk/pull/16413

3 21

RFR: 8324832: JFR: Improve sorting of 'jfr summary'
by Erik Gahlin 22 Feb '24

22 Feb '24

Could I have a review of a change that improves the sorting for the summary command. Testing: /test/jdk/jdk/jfr/tool Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/17637/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17637&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8324832 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17637.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17637/head:pull/17637 PR: https://git.openjdk.org/jdk/pull/17637

2 2

Re: RFR: JDK-8324287: Record total and free swap space in JFR [v7]
by Matthias Baesken 01 Feb '24

01 Feb '24

> Total and free swap space should be recorded in JFR, because it is important to know e.g. in case of memory shortages. > > Currently we only have a container related event (ContainerMemoryUsage) that provides some info but no general event. > PhysicalMemory could be enhanced or a new event added. > > There is already some coding (see Java_com_sun_management_internal_OperatingSystemImpl_getTotalSwapSpaceSize0 and > Java_com_sun_management_internal_OperatingSystemImpl_getFreeSwapSpaceSize0) for the swap space info retrieval. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Adjust test ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17581/files - new: https://git.openjdk.org/jdk/pull/17581/files/ca81d40a..94878ea0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17581&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17581&range=05-06 Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17581.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17581/head:pull/17581 PR: https://git.openjdk.org/jdk/pull/17581

3 4

Re: RFR: 8324974: JFR: EventCompilerPhase should be created as UNTIMED
by Erik Gahlin 31 Jan '24

31 Jan '24

On Tue, 30 Jan 2024 15:15:24 GMT, Denghui Dong <ddong(a)openjdk.org> wrote: > Hi, > > Please help review this fix. > > CompilerEvent::PhaseEvent::post will set the _start_time of EventCompilerPhase, so EventCompilerPhase should be created as UNTIMED. > > Thanks. Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/17632#pullrequestreview-1854115950

1 0

Re: RFR: 8324974: JFR: EventCompilerPhase should be created as UNTIMED
by Denghui Dong 31 Jan '24

31 Jan '24

On Tue, 30 Jan 2024 15:15:24 GMT, Denghui Dong <ddong(a)openjdk.org> wrote: > Hi, > > Please help review this fix. > > CompilerEvent::PhaseEvent::post will set the _start_time of EventCompilerPhase, so EventCompilerPhase should be created as UNTIMED. > > Thanks. testing: jdk/jfr all passed. (release build) ------------- PR Comment: https://git.openjdk.org/jdk/pull/17632#issuecomment-1919172870

1 0

Re: RFR: JDK-8324287: Record total and free swap space in JFR [v6]
by Matthias Baesken 31 Jan '24

31 Jan '24

> Total and free swap space should be recorded in JFR, because it is important to know e.g. in case of memory shortages. > > Currently we only have a container related event (ContainerMemoryUsage) that provides some info but no general event. > PhysicalMemory could be enhanced or a new event added. > > There is already some coding (see Java_com_sun_management_internal_OperatingSystemImpl_getTotalSwapSpaceSize0 and > Java_com_sun_management_internal_OperatingSystemImpl_getFreeSwapSpaceSize0) for the swap space info retrieval. Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: some Linux container related adjustments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17581/files - new: https://git.openjdk.org/jdk/pull/17581/files/e3bcb12a..ca81d40a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17581&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17581&range=04-05 Stats: 28 lines in 2 files changed: 15 ins; 9 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/17581.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17581/head:pull/17581 PR: https://git.openjdk.org/jdk/pull/17581

3 3

Re: RFR: JDK-8324287: Record total and free swap space in JFR [v5]
by Severin Gehwolf 30 Jan '24

30 Jan '24

On Mon, 29 Jan 2024 15:16:48 GMT, Matthias Baesken <mbaesken(a)openjdk.org> wrote: >> Total and free swap space should be recorded in JFR, because it is important to know e.g. in case of memory shortages. >> >> Currently we only have a container related event (ContainerMemoryUsage) that provides some info but no general event. >> PhysicalMemory could be enhanced or a new event added. >> >> There is already some coding (see Java_com_sun_management_internal_OperatingSystemImpl_getTotalSwapSpaceSize0 and >> Java_com_sun_management_internal_OperatingSystemImpl_getFreeSwapSpaceSize0) for the swap space info retrieval. > > Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: > > Linux: container support in os::total_swap_space src/hotspot/os/linux/os_linux.cpp line 294: > 292: jlong os::total_swap_space() { > 293: if (OSContainer::is_containerized()) { > 294: return (jlong)(OSContainer::memory_and_swap_limit_in_bytes() - OSContainer::memory_limit_in_bytes()); Shouldn't we check if `OSContainer::memory_limit_in_bytes() > 0` here first? src/hotspot/os/linux/os_linux.cpp line 313: > 311: } > 312: return (jlong)(si.freeswap * si.mem_unit); > 313: } In a containerized environment with some memory limit this could potentially return a large value for `free_swap_space()`, and a small(er) value for `total_swap_space()`. i.e. `total_swap_space() < free_swap_space()`. Please return `-1` if the containerized value is not supported. Better yet, push the implementation to `Linux::free_swap_space()` and `Linux::total_swap_space()` which always returns host swap values and do the (container) wrappers here in `os::free_swap_space()` and `os::total_swap_space()`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17581#discussion_r1469776435 PR Review Comment: https://git.openjdk.org/jdk/pull/17581#discussion_r1469773728

2 1