December 2024 - hotspot-jfr-dev

RFR: 8310996: Add JFR event for connect operations
by Tim Prinzing 17 Feb '25

17 Feb '25

Adds a JFR event for socket connect operations. Existing tests TestSocketEvents and TestSocketChannelEvents modified to also check for connect events. ------------- Commit messages: - fix default settings - fix merge - Merge branch 'master' into JDK-8310996 - added tests and support for sockets. - 8310996: Add JFR event for connect operations Changes: https://git.openjdk.org/jdk/pull/21528/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21528&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310996 Stats: 247 lines in 12 files changed: 236 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/21528.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21528/head:pull/21528 PR: https://git.openjdk.org/jdk/pull/21528

6 42

RFR: 8344191: Build code should not have classpath exception
by Magnus Ihse Bursie 15 Jan '25

15 Jan '25

In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data. The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception. This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience) ------------- Commit messages: - Update build tools, data and IDE support - Update makefiles, autoconf, shell scripts, properties files and configuration files Changes: https://git.openjdk.org/jdk/pull/22104/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344191 Stats: 2054 lines in 555 files changed: 0 ins; 1118 del; 936 mod Patch: https://git.openjdk.org/jdk/pull/22104.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22104/head:pull/22104 PR: https://git.openjdk.org/jdk/pull/22104

6 7

Socket Read event always reads 5B on jdk 23.0.1+11
by Steven Schlansker 09 Jan '25

09 Jan '25

Hi hotspot-jfr-dev, I am trying to track down a problem with long db queries - Java reports 10s, but the database server says the query only took 100ms. In the flight recording, I look up the Socket Read events and indeed find my suspiciously long read event. However, the event reports that only 5B are read, which is hard to believe. In fact, *every* socket read event reports exactly 5B read. This seems impossible - the server builds a 45MB response body, and all the data comes from the database. Should I expect that the socket read event reliably reports Bytes Read? I don't believe this socket stream uses asynchronous IO, which doesn't seem to be recorded at all (bummer!) I tried to read the Socket$SocketInputStream Java code but the instrumentation seems to happen due to much deeper magic. We run openjdk 23.0.1+11 on rockylinux 9.5 Example event log, subset: Start Time Duration End Time Event Thread Remote Address Bytes Read End of Stream Remote Host Remote Port Timeout Value Event Type Id 1734454183069711840 epochns 24210111038 ticks 3815799226963477504 epochticks company-server-56 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454183748414110 epochns 20222774822 ticks 3815799224469286400 epochticks company-server-39 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454590578194253 epochns 4759793838 ticks 3815800104031821312 epochticks company-server-59 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454441187707733 epochns 4751996960 ticks 3815799775364954112 epochticks company-server-42 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454425227497984 epochns 4120098692 ticks 3815799739620594688 epochticks company-server-39 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454241790648566 epochns 1079527886 ticks 3815799333018955264 epochticks company-server-55 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454590289810962 epochns 884150534 ticks 3815800099521735168 epochticks company-server-47 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead 1734454649681226560 epochns 757929740 ticks 3815800230056628736 epochticks company-server-47 10.28.224.20 5 B false wsdb 5432 0 ms jdk.SocketRead An example stack trace for one of the events: void jdk.internal.event.SocketReadEvent.emit(long, long, long, SocketAddress, long) int java.net.Socket$SocketInputStream.read(byte[], int, int) int sun.security.ssl.SSLSocketInputRecord.read(InputStream, byte[], int, int) int sun.security.ssl.SSLSocketInputRecord.readHeader() int sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket() ByteBuffer sun.security.ssl.SSLSocketImpl.readApplicationRecord(ByteBuffer) int sun.security.ssl.SSLSocketImpl$AppInputStream.read(byte[], int, int) boolean org.postgresql.core.VisibleBufferedInputStream.readMore(int, boolean) boolean org.postgresql.core.VisibleBufferedInputStream.ensureBytes(int, boolean) boolean org.postgresql.core.VisibleBufferedInputStream.ensureBytes(int) int org.postgresql.core.VisibleBufferedInputStream.read() int org.postgresql.core.PGStream.receiveChar() void org.postgresql.core.v3.QueryExecutorImpl.processResults(ResultHandler, int, boolean) void org.postgresql.core.v3.QueryExecutorImpl.execute(Query, ParameterList, ResultHandler, int, int, int, boolean) void org.postgresql.jdbc.PgStatement.executeInternal(CachedQuery, ParameterList, int) void org.postgresql.jdbc.PgStatement.execute(CachedQuery, ParameterList, int) boolean org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(int) boolean org.postgresql.jdbc.PgPreparedStatement.execute() boolean com.zaxxer.hikari.pool.ProxyPreparedStatement.execute() boolean com.zaxxer.hikari.pool.HikariProxyPreparedStatement.execute() Thank you for any insight - happy to provide more information if possible.

2 1

RFR: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that improves the query language for 'jfr view' so it can handle a wildcard with multiple event types, e.g. "SELECT * FROM E1, E2". Every field has an index which corresponds to where it is located in resultFields array. Today, the same index can appear multiple times. See FieldBuilder::createWildcardField how this can happen when there are multiple event/filter types. The fix is to set the index after all fields have been added. Testing: jdk/jdk/jfr + manual check Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/22711/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346099 Stats: 10 lines in 2 files changed: 8 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/22711.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22711/head:pull/22711 PR: https://git.openjdk.org/jdk/pull/22711

2 2

RFR: 8346047: JFR: Incorrect percentile value in 'jfr view'
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that fixes an issue with 'jfr view' when calculating the percentile. It would be possible to create a separate variable for the truncated doubleIndex, but I think this is easier to read than introducing fourth index variable. Testing: jdk/jdk/rf Thanks Erik ------------- Commit messages: - Remove incorrectly added file - Initial Changes: https://git.openjdk.org/jdk/pull/22700/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22700&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346047 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/22700.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22700/head:pull/22700 PR: https://git.openjdk.org/jdk/pull/22700

2 2

RFR: 8346052: JFR: Incorrect average value in 'jfr view'
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that fixes an issue with 'jfr view' when calculating the average for a timespan. Testing: jdk/jdk/rf Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/22699/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22699&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346052 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/22699.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22699/head:pull/22699 PR: https://git.openjdk.org/jdk/pull/22699

2 2

RFR: 8345337: JFR: jfr view should display all direct subfields for an event type
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of a PR that fixes an issue when displaying subfields with 'jfr view' Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Remove accidentally added file - Initial Changes: https://git.openjdk.org/jdk/pull/22498/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22498&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345337 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/22498.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22498/head:pull/22498 PR: https://git.openjdk.org/jdk/pull/22498

3 3

RFR: 8344080: Return type mismatch for jfr_unregister_stack_filter
by Markus Grönlund 31 Dec '24

31 Dec '24

Greetings, Tiny adjustment to function declaration. Test: jdk_jfr Thanks Markus ------------- Commit messages: - 8344080 Changes: https://git.openjdk.org/jdk/pull/22068/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22068&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344080 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/22068.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22068/head:pull/22068 PR: https://git.openjdk.org/jdk/pull/22068

4 6

RFR: 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out
by Leonid Mesnik 14 Dec '24

14 Dec '24

The test Test jdk/jfr/event/oldobject/TestSanityDefault.java timed out with non G1 GC. It is no regression, just was not executed in this configuration. It might be not reliably trigger event for non G1 GC/ with VM flags and should not be executed this. ------------- Commit messages: - 8344453: Test jdk/jfr/event/oldobject/TestSanityDefault.java timed Changes: https://git.openjdk.org/jdk/pull/22726/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22726&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344453 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/22726.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22726/head:pull/22726 PR: https://git.openjdk.org/jdk/pull/22726

2 2

RFR: 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless
by Leonid Mesnik 06 Dec '24

06 Dec '24

Test jdk/jfr/startupargs/TestStartDuration.java checks duration, the time might be too small for stress options like Xcomp. So it makes sense to mark it as flaglesss. ------------- Commit messages: - 8340969: jdk/jfr/startupargs/TestStartDuration.java should be marked as flagless Changes: https://git.openjdk.org/jdk/pull/21237/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21237&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340969 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/21237.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21237/head:pull/21237 PR: https://git.openjdk.org/jdk/pull/21237

3 3