June 2024 - hotspot-jfr-dev

RFR: 8334031: Generated JfrNativeSettings seems off
by Robert Toyonaga 04 Jul '24

04 Jul '24

This PR changes GenerateJfrFiles.java so that the generated `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` is meant to hold the settings for JFR events, but previously also included JFR structs such as MetaspaceSizes, StackFrame, CopyFailed, G1EvacuationStatistics, ObjectSpace, VirtualSpace. These are not events, but instead are JFR `Type`s, and so do not have settings such as stacktraces or thresholds. The inclusion of JFR structs in `JfrNativeSettings` was problematic because it could cause a displacement between event ID and`JfrNativeSettings` array index (each index is meant to correspond with a specific event ID). Testing: - jdk/jdk/jfr - tier1 ------------- Commit messages: - Don't include JFR structs in the list of JFR events in generated files. Changes: https://git.openjdk.org/jdk/pull/19891/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334031 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19891.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19891/head:pull/19891 PR: https://git.openjdk.org/jdk/pull/19891

3 8

RFR: 8335290: Rename ClassFile::transform to ClassFile::transformClass
by Chen Liang 28 Jun '24

28 Jun '24

`ClassFile::transform` was initially `ClassModel::transform`, which transforms the receiver class model to a new class byte array. This functionality was in parallel with `ClassBuilder::transform`, which accepts a `ClassModel` and a `ClassTransform` and forwards the results to the receiver builder. After the `ClassFile` context object introduction, `ClassModel::transform` becomes `ClassFile::transform`; now, its role is more similar to `ClassBuilder::transformMethod`, `ClassBuilder::transformField`, or `MethodBuilder::transformCode` (transforming subtypes), and it is confusing with `ClassFileBuilder::transform` (which accepts the same model type as the built type). We should rename `ClassFile::transform` to `ClassFile::transformClass` to make this method's role more clear. This is separate from #19928 as this has much more user impact. ------------- Commit messages: - Doc typo - Missed 3 files - ClassFile.transform -> transformClass Changes: https://git.openjdk.org/jdk/pull/19952/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19952&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335290 Stats: 177 lines in 58 files changed: 2 ins; 5 del; 170 mod Patch: https://git.openjdk.org/jdk/pull/19952.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19952/head:pull/19952 PR: https://git.openjdk.org/jdk/pull/19952

1 0

[jdk23] RFR: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
by Erik Gahlin 27 Jun '24

27 Jun '24

8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop ------------- Commit messages: - Backport 0e6b0cbaaa0d5272f60ee4fe09cf5e247e68c2a8 Changes: https://git.openjdk.org/jdk/pull/19932/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19932&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334886 Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19932.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19932/head:pull/19932 PR: https://git.openjdk.org/jdk/pull/19932

2 2

RFR: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
by Erik Gahlin 27 Jun '24

27 Jun '24

Could I have a review of a PR that fixes an intermittent failure. I have not been able to reproduce the failure after running the test 10 000 times, but it does reproduce quite easily without the fix. It could be that the method awaitUniqueTimestamp() could be removed completely with the introduction of a similar method in https://github.com/openjdk/jdk/pull/19799 (which happens before the chunk rotation), but I rather fix it separately. I want this change to be suitable for a backport to JDK 23 and without additional regressions. Thanks Erik ------------- Commit messages: - Remove accidentally added file - Initial Changes: https://git.openjdk.org/jdk/pull/19892/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334886 Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19892.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19892/head:pull/19892 PR: https://git.openjdk.org/jdk/pull/19892

2 2

RFR: 8310994: Add JFR event for selection operations
by Tim Prinzing 25 Jun '24

25 Jun '24

Added mirror event with static methods: jdk.internal.event.SelectionEvent that provides the duration of select calls and the count of how many keys are available. Emit the event from SelectorImpl::lockAndDoSelect Test at jdk.jfr.event.io.TestSelectionEvents ------------- Commit messages: - remove trailing whitespace - event logic outside of the lock, selector in try block - remove unused import - fix TestConfigure failure - add event defaults - Merge branch 'master' into JDK-8310994 - minor test cleanup - Merge branch 'master' into JDK-8310994 - 8310994: Add JFR event for selection operations Changes: https://git.openjdk.org/jdk/pull/16710/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16710&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310994 Stats: 265 lines in 9 files changed: 264 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/16710.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16710/head:pull/16710 PR: https://git.openjdk.org/jdk/pull/16710

6 40

[jdk23] RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
by Erik Gahlin 24 Jun '24

24 Jun '24

8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" ------------- Commit messages: - Backport bdd96604ae55ba0cd3cd3363e2ba44205d8aa3aa Changes: https://git.openjdk.org/jdk/pull/19822/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19822&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323196 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk/pull/19822.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19822/head:pull/19822 PR: https://git.openjdk.org/jdk/pull/19822

2 2

RFR: 8334765: JFR: Log chunk waste
by Erik Gahlin 24 Jun '24

24 Jun '24

Could I have a review of PR that adds logging of chunk waste. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Updates - Initial Changes: https://git.openjdk.org/jdk/pull/19845/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19845&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334765 Stats: 32 lines in 2 files changed: 29 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/19845.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19845/head:pull/19845 PR: https://git.openjdk.org/jdk/pull/19845

2 3

RFR: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
by Erik Gahlin 21 Jun '24

21 Jun '24

Could I have a review of a test fix. Order is only guaranteed within a batch of events (stated by the EventStream class specification). If a recording with multiple segments/batches are created, retry. Testing: 100 * jdk/jfr/api/consumer/filestream/TestOrdered.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/19811/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19811&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8323196 Stats: 37 lines in 1 file changed: 16 ins; 0 del; 21 mod Patch: https://git.openjdk.org/jdk/pull/19811.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19811/head:pull/19811 PR: https://git.openjdk.org/jdk/pull/19811

2 2

[jdk23] RFR: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
by Erik Gahlin 20 Jun '24

20 Jun '24

8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events" ------------- Commit messages: - Backport 856931d01f14b1c665c04e05d5637b8237c56988 Changes: https://git.openjdk.org/jdk/pull/19799/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19799&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304732 Stats: 190 lines in 17 files changed: 120 ins; 36 del; 34 mod Patch: https://git.openjdk.org/jdk/pull/19799.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19799/head:pull/19799 PR: https://git.openjdk.org/jdk/pull/19799

2 2

RFR: 8304732: jdk/jfr/api/consumer/recordingstream/TestStop.java failed again with "Expected outer stream to have 3 events"
by Erik Gahlin 19 Jun '24

19 Jun '24

Could I have review of change that hopefully will fix intermittent failures for TestStop.java. I have run the test 20 000 times without a failure. If I remove the changed code, I can reproduce the failure. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/19681/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19681&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304732 Stats: 64 lines in 4 files changed: 48 ins; 4 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/19681.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19681/head:pull/19681 PR: https://git.openjdk.org/jdk/pull/19681

2 5