July 2024 - hotspot-jfr-dev

Re: RFR: 8334781: JFR crash: assert(((((JfrTraceIdBits::load(klass)) & ((JfrTraceIdEpoch::this_epoch_method_and_class_bits()))) != 0))) failed: invariant
by Erik Gahlin 13 Jul '24

13 Jul '24

On Sat, 13 Jul 2024 14:47:21 GMT, Markus Grönlund <mgronlun(a)openjdk.org> wrote: > Greetings, > > Please help review this adjustment, which fixes rare situations where methods that have been retransformed or redefined can be perceived as being tagged by JFR when they, in fact, are not. The fix unconditionally sets the metatag clear bits on artefact initialization and adds assertions about the JFR bit tag state machine. > > Testing: jdk_jfr, stress testing > > Thanks > Markus Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/20171#pullrequestreview-2176439194

1 0

RFR: 8335905: CompoundElement API cleanup
by Chen Liang 09 Jul '24

09 Jul '24

`CompoundElement` already inherits `Iterable` and its `forEach(Consumer)`, thus we can remove `Iterable elements()` and `forEachElements(Consumer)`. ------------- Commit messages: - Missed tests - 8335905: CompoundElement API cleanup Changes: https://git.openjdk.org/jdk/pull/20103/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20103&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335905 Stats: 83 lines in 32 files changed: 2 ins; 11 del; 70 mod Patch: https://git.openjdk.org/jdk/pull/20103.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20103/head:pull/20103 PR: https://git.openjdk.org/jdk/pull/20103

1 0

RFR: 8335779: JFR: Hide sleep events
by Erik Gahlin 08 Jul '24

08 Jul '24

Could I have review of an enhancement that hides remaining "threads sleep" events in the JFR code. This is to reduce the noise some users experience. Testing: jdk/jdk/jfr/* + 1500 * jdk/jdk/jfr/jvm/TestHiddenEvent.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/20075/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20075&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335779 Stats: 301 lines in 15 files changed: 170 ins; 78 del; 53 mod Patch: https://git.openjdk.org/jdk/pull/20075.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20075/head:pull/20075 PR: https://git.openjdk.org/jdk/pull/20075

1 0

RFR: 8335632: jdk/jfr/api/consumer/streaming/TestJVMExit.java failed with "Process [...] is no longer alive"
by Erik Gahlin 05 Jul '24

05 Jul '24

Could I have a review of a test fix? Testing: 100 * jdk/jdk/jfr/consumer/streaming/TestJVMExit.java Thanks. Erik ------------- Commit messages: - Change build directive to TestProcess - Initial Changes: https://git.openjdk.org/jdk/pull/20043/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20043&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335632 Stats: 17 lines in 1 file changed: 17 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/20043.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20043/head:pull/20043 PR: https://git.openjdk.org/jdk/pull/20043

2 2

RFR: 8335730: JFR: Clean up jdk.jfr
by Erik Gahlin 05 Jul '24

05 Jul '24

Could I have review of a PR that: - remove unused imports - remove unused variables in instanceof - use constants instead Integer.valueOf(-1) or Long.valueOf(0L) - add final where missing - prefer package protected classes over public - use try-with-resources - use Arrays.toString(...) instead of Arrays.asList(...).toString(); Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/20042/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20042&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335730 Stats: 58 lines in 24 files changed: 3 ins; 22 del; 33 mod Patch: https://git.openjdk.org/jdk/pull/20042.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20042/head:pull/20042 PR: https://git.openjdk.org/jdk/pull/20042

2 2

[jdk23] RFR: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
by Erik Gahlin 05 Jul '24

05 Jul '24

8335479: JFR: Missing documentation for -XX:StartFlightRecording ------------- Commit messages: - Backport 68ffec9800b798927a050900a2d47000aa18ef30 Changes: https://git.openjdk.org/jdk/pull/20029/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20029&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335479 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/20029.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20029/head:pull/20029 PR: https://git.openjdk.org/jdk/pull/20029

2 2

RFR: 8334031: Generated JfrNativeSettings seems off
by Robert Toyonaga 04 Jul '24

04 Jul '24

This PR changes GenerateJfrFiles.java so that the generated `JfrNativeSettings` union does not include JFR structs.`JfrNativeSettings` is meant to hold the settings for JFR events, but previously also included JFR structs such as MetaspaceSizes, StackFrame, CopyFailed, G1EvacuationStatistics, ObjectSpace, VirtualSpace. These are not events, but instead are JFR `Type`s, and so do not have settings such as stacktraces or thresholds. The inclusion of JFR structs in `JfrNativeSettings` was problematic because it could cause a displacement between event ID and`JfrNativeSettings` array index (each index is meant to correspond with a specific event ID). Testing: - jdk/jdk/jfr - tier1 ------------- Commit messages: - Don't include JFR structs in the list of JFR events in generated files. Changes: https://git.openjdk.org/jdk/pull/19891/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19891&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334031 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19891.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19891/head:pull/19891 PR: https://git.openjdk.org/jdk/pull/19891

3 8

RFR: 8335479: JFR: Missing documentation for -XX:StartFlightRecording
by Erik Gahlin 03 Jul '24

03 Jul '24

Could I have a review of updates to the -XX:StartFlightRecording option for JFR. Testing: tier1 Thanks Erik ------------- Commit messages: - Remove accidentally added file - Initial Changes: https://git.openjdk.org/jdk/pull/19992/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19992&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8335479 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19992.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19992/head:pull/19992 PR: https://git.openjdk.org/jdk/pull/19992

2 2