January 2025 - hotspot-jfr-dev

RFR: 8345500: Timeout in jdk.jfr.api.consumer.streaming.TestJVMCrash
by Gerard Ziemski 09 May '25

09 May '25

In this fix we add 1 second delay after we create a process. On macOS we seem to be creating a process so quickly, that other threads need time to see it. ------------- Commit messages: - allow process to be visible by other threads Changes: https://git.openjdk.org/jdk/pull/23163/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23163&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345500 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/23163.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23163/head:pull/23163 PR: https://git.openjdk.org/jdk/pull/23163

3 3

RFR: 8310996: Add JFR event for connect operations
by Tim Prinzing 17 Feb '25

17 Feb '25

Adds a JFR event for socket connect operations. Existing tests TestSocketEvents and TestSocketChannelEvents modified to also check for connect events. ------------- Commit messages: - fix default settings - fix merge - Merge branch 'master' into JDK-8310996 - added tests and support for sockets. - 8310996: Add JFR event for connect operations Changes: https://git.openjdk.org/jdk/pull/21528/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21528&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310996 Stats: 247 lines in 12 files changed: 236 ins; 3 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/21528.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21528/head:pull/21528 PR: https://git.openjdk.org/jdk/pull/21528

6 42

RFR: 8348430: Update jfr tests to allow execution with different vm flags
by Erik Gahlin 31 Jan '25

31 Jan '25

Could I have review of a change that allows some tests to run with flags. Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/23369/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23369&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8348430 Stats: 10 lines in 10 files changed: 0 ins; 10 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/23369.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23369/head:pull/23369 PR: https://git.openjdk.org/jdk/pull/23369

2 2

Integrated: 8318098: Update jfr tests to replace keyword jfr with vm.flagless
by Leonid Mesnik 25 Jan '25

25 Jan '25

On Fri, 24 Jan 2025 01:08:31 GMT, Leonid Mesnik <lmesnik(a)openjdk.org> wrote: > A lot of jfr tests are very specific. Currently all of them are marked with jfr keyword and excluded when VM flags are set. > > It makes sense to mark them with @requires <something> to be complaint with all other openjdk tests. > The next step is to review tests and remove vm.flagless from tests that should be executed with different VM flags. > > Bug https://bugs.openjdk.org/browse/JDK-8318097 is filed for this activity. This pull request has now been integrated. Changeset: 99002e4f Author: Leonid Mesnik <lmesnik(a)openjdk.org> URL: https://git.openjdk.org/jdk/commit/99002e4f9d421d08d912187a1f01809d85820427 Stats: 1090 lines in 582 files changed: 2 ins; 0 del; 1088 mod 8318098: Update jfr tests to replace keyword jfr with vm.flagless Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/23285

1 0

Re: RFR: 8318098: Update jfr tests to replace keyword jfr with vm.flagless
by Markus Grönlund 24 Jan '25

24 Jan '25

On Fri, 24 Jan 2025 01:08:31 GMT, Leonid Mesnik <lmesnik(a)openjdk.org> wrote: > A lot of jfr tests are very specific. Currently all of them are marked with jfr keyword and excluded when VM flags are set. > > It makes sense to mark them with @requires <something> to be complaint with all other openjdk tests. > The next step is to review tests and remove vm.flagless from tests that should be executed with different VM flags. > > Bug https://bugs.openjdk.org/browse/JDK-8318097 is filed for this activity. Blanket review. Did not check all files. ------------- Marked as reviewed by mgronlun (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23285#pullrequestreview-2572300298

1 0

RFR: 8346875: Test jdk/jdk/jfr/event/os/TestCPULoad.java fails on macOS
by Matthias Baesken 24 Jan '25

24 Jan '25

The test fails on some new Mac instances (macOS 14.5 (macOS aarch64) , CPU Apple M2) with : java.lang.AssertionError: Expected at least one event at jdk.jfr.event.os.TestCPULoad.main(TestCPULoad.java:62) at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104) at java.base/java.lang.reflect.Method.invoke(Method.java:565) at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138) at java.base/java.lang.Thread.run(Thread.java:1447) The current sleep value seems to be a bit too slow for those machines. The issues occured (mostly) with fastdebug binaries. ------------- Commit messages: - JDK-8346875 Changes: https://git.openjdk.org/jdk/pull/23136/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23136&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346875 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/23136.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23136/head:pull/23136 PR: https://git.openjdk.org/jdk/pull/23136

2 10

RFR: 8347922: Remove runtime/cds/appcds/customLoader/HelloCustom_JFR.java from ProblemList.txt and TEST.groups
by Markus Grönlund 20 Jan '25

20 Jan '25

Greetings, Removing the HelloCustom_JFR.java test exclusion from ProblemList.txt and TEST.groups. Testing: Repeated testing of HelloCustom_JFR.java with and without -XX:+UseZGC. Thanks Markus ------------- Commit messages: - 8347922 Changes: https://git.openjdk.org/jdk/pull/23158/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23158&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347922 Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/23158.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23158/head:pull/23158 PR: https://git.openjdk.org/jdk/pull/23158

2 4

RFR: 8344191: Build code should not have classpath exception
by Magnus Ihse Bursie 15 Jan '25

15 Jan '25

In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build tools and data. The only places where the classpath exception is still kept in the make directory is as text strings in some build tools, which generate source code that is bundled with `src.zip`, and thus *must* have the classpath exception. This is a huge and autogenerated, but content-wise trivial, PR, and I know such are hard to review. I recommend looking at the entire diff file instead of checking this file-by-file in the Github web GUI. (That's bound to be a painful experience) ------------- Commit messages: - Update build tools, data and IDE support - Update makefiles, autoconf, shell scripts, properties files and configuration files Changes: https://git.openjdk.org/jdk/pull/22104/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8344191 Stats: 2054 lines in 555 files changed: 0 ins; 1118 del; 936 mod Patch: https://git.openjdk.org/jdk/pull/22104.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22104/head:pull/22104 PR: https://git.openjdk.org/jdk/pull/22104

6 7

[jdk24] RFR: 8345493: JFR: JVM.flush hangs intermittently
by Markus Grönlund 15 Jan '25

15 Jan '25

8345493: JFR: JVM.flush hangs intermittently ------------- Commit messages: - Backport 4257215a9fa02f74ccd4fc62893d4b1a232a8754 Changes: https://git.openjdk.org/jdk/pull/23141/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23141&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345493 Stats: 9 lines in 2 files changed: 7 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/23141.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23141/head:pull/23141 PR: https://git.openjdk.org/jdk/pull/23141

2 2

RFR: 8345493: JFR: JVM.flush hangs intermittently
by Markus Grönlund 15 Jan '25

15 Jan '25

Greetings, This is a hypothetical fix for JDK-8345493, because the issue seems impossible to reproduce, even with instrumentation and extra debug information. Debugging .mdmp state indicates that a message request thread is not woken up from waiting on a condition variable, even as the sent-in message has been processed. Both the message request thread and the consumer wait on the condition variable instead. This means the message request thread does not wake up to check that its message has been processed. There is a bit of designed asymmetry in that only a single message thread should be waiting for a message to be processed. The consumer, therefore, signals it using notify(). Let's say we have a broken invariant somewhere (not yet found) that allows two threads to post messages—notify() will only wake up a single thread from the associated condition variable. A safer, intermediate "fix" is to let the consumer issue a notify_all() to wake all potential waiters. We will continue to investigate the underlying cause but suggest this as an intermediate fix. Testing: jdk_jfr, stress testing. Thanks Markus ------------- Commit messages: - 8345493 Changes: https://git.openjdk.org/jdk/pull/23105/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23105&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345493 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/23105.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23105/head:pull/23105 PR: https://git.openjdk.org/jdk/pull/23105

2 4