January 2025 - hotspot-jfr-dev

RFR: 8347042: Remove an extra parenthesis in macro definition in `jfrTraceIdMacros.hpp`
by Qizheng Xing 09 Jan '25

09 Jan '25

The macro definition `METHOD_USED_ANY_EPOCH` in `jfrTraceIdMacros.hpp` has an extra parenthesis, which was introduced in JDK-8233705. But there seems to be no code using this macro, so there are no related build failures so far. This patch removes the extra parenthesis. ------------- Commit messages: - Remove an extra parenthesis in macro definition in `jfrTraceIdMacros.hpp`. Changes: https://git.openjdk.org/jdk/pull/22925/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22925&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8347042 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/22925.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22925/head:pull/22925 PR: https://git.openjdk.org/jdk/pull/22925

4 5

RFR: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that improves the query language for 'jfr view' so it can handle a wildcard with multiple event types, e.g. "SELECT * FROM E1, E2". Every field has an index which corresponds to where it is located in resultFields array. Today, the same index can appear multiple times. See FieldBuilder::createWildcardField how this can happen when there are multiple event/filter types. The fix is to set the index after all fields have been added. Testing: jdk/jdk/jfr + manual check Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/22711/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22711&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346099 Stats: 10 lines in 2 files changed: 8 ins; 2 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/22711.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22711/head:pull/22711 PR: https://git.openjdk.org/jdk/pull/22711

2 2

RFR: 8346047: JFR: Incorrect percentile value in 'jfr view'
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that fixes an issue with 'jfr view' when calculating the percentile. It would be possible to create a separate variable for the truncated doubleIndex, but I think this is easier to read than introducing fourth index variable. Testing: jdk/jdk/rf Thanks Erik ------------- Commit messages: - Remove incorrectly added file - Initial Changes: https://git.openjdk.org/jdk/pull/22700/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22700&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346047 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/22700.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22700/head:pull/22700 PR: https://git.openjdk.org/jdk/pull/22700

2 2

Re: RFR: 8347124: Clean tests with --enable-linkable-runtime
by Alan Bateman 08 Jan '25

08 Jan '25

On Wed, 8 Jan 2025 14:24:25 GMT, Severin Gehwolf <sgehwolf(a)openjdk.org> wrote: > Please review this trivial test-only patch in support of running tests on JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run `jlink` in-process of the test JVM which includes module patches (as in - uses `--patch-module`) which is not supported for JEP 493 enabled JDKs. The proposed fix is to run those two tests in `/othervm` so as to no longer see the module patch of the test JDK. > > Testing: > - [ ] GHA > - [x] Affected tests which fail prior the patch and pass after with a JEP 493 enabled JDK. Also tested on a JDK that includes `jmods` folder. > > Thoughts? test/jdk/tools/launcher/SourceMode.java line 29: > 27: * @summary Test source mode > 28: * @modules jdk.compiler jdk.jlink > 29: * @run main/othervm SourceMode This looks fine, might need to add `@comment` to something brief to say why the test are othervm. Also I assume you'll bump the copyright header on the tests before ingtegrating. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22969#discussion_r1907293028

2 1

RFR: 8346052: JFR: Incorrect average value in 'jfr view'
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of PR that fixes an issue with 'jfr view' when calculating the average for a timespan. Testing: jdk/jdk/rf Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/22699/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22699&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346052 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/22699.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22699/head:pull/22699 PR: https://git.openjdk.org/jdk/pull/22699

2 2

RFR: 8345337: JFR: jfr view should display all direct subfields for an event type
by Erik Gahlin 08 Jan '25

08 Jan '25

Could I have a review of a PR that fixes an issue when displaying subfields with 'jfr view' Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Remove accidentally added file - Initial Changes: https://git.openjdk.org/jdk/pull/22498/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22498&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345337 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/22498.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22498/head:pull/22498 PR: https://git.openjdk.org/jdk/pull/22498

3 3

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages [v2]
by Adam Sotona 06 Jan '25

06 Jan '25

> This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: updated copyright year ------------- Changes: - all: https://git.openjdk.org/jdk/pull/22912/files - new: https://git.openjdk.org/jdk/pull/22912/files/06ec27bf..f8fe6546 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=22912&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22912&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/22912.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/22912/head:pull/22912 PR: https://git.openjdk.org/jdk/pull/22912

3 3

Integrated: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
by Adam Sotona 06 Jan '25

06 Jan '25

On Fri, 3 Jan 2025 12:06:05 GMT, Adam Sotona <asotona(a)openjdk.org> wrote: > This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module. > > Please review. > > Thanks, > Adam This pull request has now been integrated. Changeset: e0695e0e Author: Adam Sotona <asotona(a)openjdk.org> URL: https://git.openjdk.org/jdk/commit/e0695e0ef0dd1bfacbaac32edda055ba852a2421 Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages Reviewed-by: liach, alanb ------------- PR: https://git.openjdk.org/jdk/pull/22912

1 0

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
by Alan Bateman 03 Jan '25

03 Jan '25

On Fri, 3 Jan 2025 12:06:05 GMT, Adam Sotona <asotona(a)openjdk.org> wrote: > This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module. > > Please review. > > Thanks, > Adam Good cleanup, these qualified exports should probably have been removed in JDK 22 when the instrumentation moved to the class file API. ------------- Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22912#pullrequestreview-2529437512

1 0

Re: RFR: 8346981: Remove obsolete java.base exports of jdk.internal.objectweb.asm packages
by Chen Liang 03 Jan '25

03 Jan '25

On Fri, 3 Jan 2025 12:06:05 GMT, Adam Sotona <asotona(a)openjdk.org> wrote: > This PR removes obsolete java.base exports of jdk.internal.objectweb.asm packages to jdk.jfr module. > > Please review. > > Thanks, > Adam Looks good; waiting for a JFR reviewer. ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/22912#pullrequestreview-2529380039

1 0