May 2025 - hotspot-jfr-dev

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v23]
by Johannes Bechberger 29 May '25

29 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 93 commits: - Fix merge - Merge branch 'master' into parttimenerd_cooperative_cpu_time_sampler - Fix merge mistake - Replace views with cpu-time-statistics view - Merge branch 'master' into parttimenerd_cooperative_cpu_time_sampler - Fix builds on non Linux platforms - Tiny fixes - Tiny fixes - Remove assertion - Remove mistake - ... and 83 more: https://git.openjdk.org/jdk/compare/79aff26c...adcbec51 ------------- Changes: https://git.openjdk.org/jdk/pull/25302/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=22 Stats: 2303 lines in 44 files changed: 2157 ins; 130 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

RFR: 8352738: Implement JEP 520: JFR Method Timing and Tracing
by Erik Gahlin 29 May '25

29 May '25

Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately. Testing: tier 1-3, test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/25306/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25306&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8352738 Stats: 7100 lines in 109 files changed: 6640 ins; 363 del; 97 mod Patch: https://git.openjdk.org/jdk/pull/25306.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25306/head:pull/25306 PR: https://git.openjdk.org/jdk/pull/25306

4 40

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v22]
by Johannes Bechberger 28 May '25

28 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Replace views with cpu-time-statistics view ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25302/files - new: https://git.openjdk.org/jdk/pull/25302/files/14f1d068..4a2cbac3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=21 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=20-21 Stats: 22 lines in 1 file changed: 0 ins; 8 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v21]
by Johannes Bechberger 28 May '25

28 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 89 commits: - Merge branch 'master' into parttimenerd_cooperative_cpu_time_sampler - Fix builds on non Linux platforms - Tiny fixes - Tiny fixes - Remove assertion - Remove mistake - Merge branch 'master' of https://git.openjdk.org/jdk into parttimenerd_cooperative_cpu_time_sampler - Fix other platforms - Improve one warning - Fix MacOS build - ... and 79 more: https://git.openjdk.org/jdk/compare/e3f85c96...14f1d068 ------------- Changes: https://git.openjdk.org/jdk/pull/25302/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=20 Stats: 2339 lines in 45 files changed: 2164 ins; 159 del; 16 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

RFR: 8357830: JfrVframeStream::_cont_entry shadows super-class field
by Markus Grönlund 28 May '25

28 May '25

Greetings, SonarCloud has a report that `JfrVframeStream::_cont_entry` shadows the super-class field of the same name. Fixed and inlined the constructor. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - avoid shadowing super-class field _cont_entry and inline Changes: https://git.openjdk.org/jdk/pull/25465/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25465&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357830 Stats: 92 lines in 3 files changed: 35 ins; 56 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25465.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25465/head:pull/25465 PR: https://git.openjdk.org/jdk/pull/25465

2 2

RFR: 8357911: JFR: Fix subtle xor method tagging bug
by Markus Grönlund 28 May '25

28 May '25

Greetings, Please see problem description in JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8357911 Changes: https://git.openjdk.org/jdk/pull/25484/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25484&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357911 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/25484.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25484/head:pull/25484 PR: https://git.openjdk.org/jdk/pull/25484

2 2

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v20]
by Johannes Bechberger 28 May '25

28 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Fix builds on non Linux platforms ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25302/files - new: https://git.openjdk.org/jdk/pull/25302/files/7c3ec247..ca6debcc Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=19 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=18-19 Stats: 6 lines in 1 file changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v19]
by Johannes Bechberger 28 May '25

28 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Tiny fixes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25302/files - new: https://git.openjdk.org/jdk/pull/25302/files/298ea428..7c3ec247 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=18 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=17-18 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

Re: RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v18]
by Johannes Bechberger 28 May '25

28 May '25

> This is the code for the [JEP 509: CPU Time based profiling for JFR](https://openjdk.org/jeps/509). > > Currently tested using [this test suite](https://github.com/parttimenerd/basic-profiler-tests). This runs profiles the [Renaissance](https://renaissance.dev/) benchmark with > - ... different heap sizes > - ... different GCs > - ... different samplers (the standard JFR and the new CPU Time Sampler and both) > - ... different JFR recording durations > - ... different chunk-sizes Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Tiny fixes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/25302/files - new: https://git.openjdk.org/jdk/pull/25302/files/d91f5672..298ea428 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=17 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25302&range=16-17 Stats: 77 lines in 6 files changed: 5 ins; 60 del; 12 mod Patch: https://git.openjdk.org/jdk/pull/25302.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25302/head:pull/25302 PR: https://git.openjdk.org/jdk/pull/25302

1 0

RFR: 8357829: Commented out sample limit in JfrSamplerThread::task_stacktrace
by Markus Grönlund 28 May '25

28 May '25

Greetings, SonarCloud identified this issue today following the integration of [JDK-8352251](https://bugs.openjdk.org/browse/JDK-8352251). It's a remnant from increased sampling pressure during development. A change will be coming in this area, just not yet. Restoring sampling limits. Testing: jdk_jfr Thanks SonarCloud! Markus ------------- Commit messages: - restore thread sample limits Changes: https://git.openjdk.org/jdk/pull/25464/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25464&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8357829 Stats: 6 lines in 1 file changed: 3 ins; 1 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25464.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25464/head:pull/25464 PR: https://git.openjdk.org/jdk/pull/25464

2 9