June 2025 - hotspot-jfr-dev

RFR: 8360201: JFR: Initialize JfrThreadLocal::_sampling_critical_section
by Aleksey Shipilev 24 Jun '25

24 Jun '25

Initially found by UBSan. I was not able to reproduce it locally, @MBaesken would try. But the problem seems obvious: the initial value for the `bool` field is garbage. I have checked other fields in `JfrThreadLocal`, they seem fine. Additional testing: - [x] Linux x86_64 server fastdebug, `jdk_jfr` ------------- Commit messages: - Fix Changes: https://git.openjdk.org/jdk/pull/25938/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25938&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8360201 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/25938.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25938/head:pull/25938 PR: https://git.openjdk.org/jdk/pull/25938

4 7

RFR: 8346886: Add since checker test to jdk.management.jfr
by Nizar Benalla 23 Jun '25

23 Jun '25

Please review this patch to add a new test to check `@since` tags in the `jdk.management.jfr` module. TIA ------------- Commit messages: - add new `@since` test Changes: https://git.openjdk.org/jdk/pull/25612/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346886 Stats: 30 lines in 1 file changed: 30 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/25612.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25612/head:pull/25612 PR: https://git.openjdk.org/jdk/pull/25612

2 3

[jdk25] RFR: 8359895: JFR: method-timing view doesn't work
by Erik Gahlin 23 Jun '25

23 Jun '25

8359895: JFR: method-timing view doesn't work ------------- Commit messages: - Backport 984d7f9cdfb0d75ea906ce32df0b6c447f4d5954 Changes: https://git.openjdk.org/jdk/pull/25901/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25901&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359895 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25901.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25901/head:pull/25901 PR: https://git.openjdk.org/jdk/pull/25901

2 2

[jdk25] RFR: 8359242: JFR: Missing help text for method trace and timing
by Erik Gahlin 23 Jun '25

23 Jun '25

8359242: JFR: Missing help text for method trace and timing ------------- Commit messages: - Backport e57a214e2a1059109dd028369d518298cfa5d5b4 Changes: https://git.openjdk.org/jdk/pull/25899/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25899&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359242 Stats: 50 lines in 7 files changed: 35 ins; 4 del; 11 mod Patch: https://git.openjdk.org/jdk/pull/25899.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25899/head:pull/25899 PR: https://git.openjdk.org/jdk/pull/25899

2 2

RFR: 8360039: JFR: Improve parser logging of constants
by Erik Gahlin 23 Jun '25

23 Jun '25

Could I have a review of the PR that improves logging in the JFR parser for arrays? Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/25903/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25903&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8360039 Stats: 23 lines in 1 file changed: 18 ins; 3 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25903.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25903/head:pull/25903 PR: https://git.openjdk.org/jdk/pull/25903

2 2

[jdk25] RFR: 8359593: JFR: Instrumentation of java.lang.String corrupts recording
by Erik Gahlin 19 Jun '25

19 Jun '25

8359593: JFR: Instrumentation of java.lang.String corrupts recording ------------- Commit messages: - Backport 2f2acb2e3f292517456f5b328a35182863188653 Changes: https://git.openjdk.org/jdk/pull/25886/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25886&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359593 Stats: 122 lines in 2 files changed: 110 ins; 5 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/25886.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25886/head:pull/25886 PR: https://git.openjdk.org/jdk/pull/25886

2 2

19 Jun '25

8359248: JFR: Help text for-XX:StartFlightRecording:report-on-exit should explain option can be repeated ------------- Commit messages: - Backport fedd0a0ee3aea9f73cfce34172a764e63c1ba46b Changes: https://git.openjdk.org/jdk/pull/25885/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25885&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359248 Stats: 9 lines in 2 files changed: 3 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/25885.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25885/head:pull/25885 PR: https://git.openjdk.org/jdk/pull/25885

2 2

RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty`
by Naoto Sato 18 Jun '25

18 Jun '25

Refactored the internal handling of `stdin/out/err.encoding` to allow setting them only via command-line options by converting them into `StaticProperty`. This change prevents unexpected behavior caused by applications modifying these properties at runtime using `System.setProperty()`. ------------- Commit messages: - Several more locations - initial commit Changes: https://git.openjdk.org/jdk/pull/25860/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25860&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359732 Stats: 69 lines in 13 files changed: 50 ins; 0 del; 19 mod Patch: https://git.openjdk.org/jdk/pull/25860.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25860/head:pull/25860 PR: https://git.openjdk.org/jdk/pull/25860

4 5

RFR: 8359895: JFR: method-timing view doesn't work
by Erik Gahlin 18 Jun '25

18 Jun '25

Could I have review of PR that fixes the method timing view. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/25869/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25869&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359895 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/25869.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25869/head:pull/25869 PR: https://git.openjdk.org/jdk/pull/25869

2 2

RFR: 8359242: JFR: Missing help text for method trace and timing
by Erik Gahlin 16 Jun '25

16 Jun '25

Could I have a review of a PR that adds missing help texts for method trace and method timing? Without, it's hard for user to understand how the feature can be used in JMC or with "jfr configure --interactive" Testing: test/jdk/jdk/jfr + tier1 Thanks Erik ------------- Commit messages: - Improve - Initial Changes: https://git.openjdk.org/jdk/pull/25759/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25759&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8359242 Stats: 54 lines in 8 files changed: 36 ins; 4 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/25759.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/25759/head:pull/25759 PR: https://git.openjdk.org/jdk/pull/25759

2 3