On Fri, 25 Nov 2022 23:44:38 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of PR that adds stop() methods to RecordingStream and RemoteRecordingStream. Purpose is to provide better control of what is being recorded.
Testing: test/jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Add @since
src/jdk.management.jfr/share/classes/jdk/management/jfr/RemoteRecordingStream.java line 615:
613: stopped = mbean.stopRecording(recordingId); 614: ManagementSupport.setCloseOnComplete(stream, false); 615: long stopTime = getRecordingInfo(mbean.getRecordings(), recordingId).getStopTime(); pb.setStreamEnd(stopTime);
Why `pb.setStreamEnd(stopTime);` is placed at the end of line here? ------------- PR: https://git.openjdk.org/jdk/pull/11337