25 Nov
2022
25 Nov
'22
4:42 p.m.
On Thu, 24 Nov 2022 07:59:43 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of PR that adds stop() methods to RecordingStream and RemoteRecordingStream. Purpose is to provide better control of what is being recorded.
Testing: test/jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Update comments
src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordingStream.java line 404:
402: * @throws IllegalStateException if the recording is not started or is already stopped 403: */ 404: public boolean stop() {
Drive-by comment, I assume you should add `@since 20` here. ------------- PR: https://git.openjdk.org/jdk/pull/11337