RFR: 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize
Hi, Could I have a review of PR that adds a warning message if maxage or maxsize is set when disk = false. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/10508/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10508&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8292336 Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/10508.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10508/head:pull/10508 PR: https://git.openjdk.org/jdk/pull/10508
On Fri, 30 Sep 2022 12:10:31 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of PR that adds a warning message if maxage or maxsize is set when disk = false.
Testing: jdk/jdk/jfr
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/10508
On Fri, 30 Sep 2022 12:10:31 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of PR that adds a warning message if maxage or maxsize is set when disk = false.
Testing: jdk/jdk/jfr
Thanks Erik
This pull request has now been integrated. Changeset: a69ee853 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/a69ee85308ae2fd5d9fd5aed69b16ca70119976a Stats: 8 lines in 1 file changed: 8 ins; 0 del; 0 mod 8292336: JFR: Warn users if -XX:StartFlightRecording:disk=false is specified with maxage or maxsize Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/10508
participants (2)
-
Erik Gahlin
-
Markus Grönlund