RFR: 8295650: JFR: jfr scrub should warn if an event type doesn't exist
Hi, It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariables" and believe events have been removed from recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data. To help users, a warning message is now written if an event filter doesn't match metadata available in the recording. Thanks Erik ------------- Commit messages: - Remove file and imports - Initial Changes: https://git.openjdk.org/jdk/pull/10779/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295650 Stats: 70 lines in 3 files changed: 52 ins; 11 del; 7 mod Patch: https://git.openjdk.org/jdk/pull/10779.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10779/head:pull/10779 PR: https://git.openjdk.org/jdk/pull/10779
Hi,
It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariables" and believe events have been removed from recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data.
To help users, a warning message is now written if an event filter doesn't match metadata available in the recording.
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Fix metadata command ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10779/files - new: https://git.openjdk.org/jdk/pull/10779/files/0af0c2f2..bd317331 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=00-01 Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10779.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10779/head:pull/10779 PR: https://git.openjdk.org/jdk/pull/10779
On Thu, 20 Oct 2022 10:47:15 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariable" and believe events have been removed from a recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data.
To help users, a warning message is now written if an event filter doesn't match metadata available in the recording.
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Fix metadata command
Marked as reviewed by mgronlun (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/10779
Hi,
It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariable" and believe events have been removed from a recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data.
To help users, a warning message is now written if an event filter doesn't match metadata available in the recording.
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Fix print command ------------- Changes: - all: https://git.openjdk.org/jdk/pull/10779/files - new: https://git.openjdk.org/jdk/pull/10779/files/bd317331..ca4d50f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10779&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/10779.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10779/head:pull/10779 PR: https://git.openjdk.org/jdk/pull/10779
On Thu, 20 Oct 2022 05:35:10 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
It's easy to do a typo when using the 'jfr scrub' command. For example, a user may type "jdk.InitialEnvironmentVariables", "jdk.EnvironmentVariable" or "InitialEnvironmentVariable" and believe events have been removed from a recording file when they should have typed "jdk.InitialEnvironmentVariable" to filter out sensitive data.
To help users, a warning message is now written if an event filter doesn't match metadata available in the recording.
Thanks Erik
This pull request has now been integrated. Changeset: f41711ef Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f41711ef63d1a14392bf5e5b9ae6939f8772e803 Stats: 77 lines in 5 files changed: 55 ins; 11 del; 11 mod 8295650: JFR: jfr scrub should warn if an event type doesn't exist Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/10779
participants (2)
-
Erik Gahlin
-
Markus Grönlund