Re: RFR: JDK-8300783: Consolidate byteswap implementations [v12]
Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.
Justin King has updated the pull request incrementally with four additional commits since the last revision: - Update copyright Signed-off-by: Justin King <jcking@google.com> - Add missing include Signed-off-by: Justin King <jcking@google.com> - Remove unused include Signed-off-by: Justin King <jcking@google.com> - Reorganize tests Signed-off-by: Justin King <jcking@google.com> ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12114/files - new: https://git.openjdk.org/jdk/pull/12114/files/d43b9f10..139c4205 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12114&range=10-11 Stats: 254 lines in 3 files changed: 152 ins; 102 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/12114.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12114/head:pull/12114 PR: https://git.openjdk.org/jdk/pull/12114
On Fri, 27 Jan 2023 17:00:58 GMT, Justin King <jcking@openjdk.org> wrote:
Deduplicate byte swapping implementations by consolidating them into `utilities/byteswap.hpp`, following `std::byteswap` introduced in C++23. Further simplification of `Bytes` will follow in https://github.com/openjdk/jdk/pull/12078.
Justin King has updated the pull request incrementally with four additional commits since the last revision:
- Update copyright
Signed-off-by: Justin King <jcking@google.com> - Add missing include
Signed-off-by: Justin King <jcking@google.com> - Remove unused include
Signed-off-by: Justin King <jcking@google.com> - Reorganize tests
Signed-off-by: Justin King <jcking@google.com>
Updates are fine - thanks. I'll try to get someone to properly review this. test/hotspot/gtest/utilities/test_byteswap.cpp line 2:
1: /* 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
As a new file this should only have 2023 copyright year - thanks. ------------- PR: https://git.openjdk.org/jdk/pull/12114
On Tue, 31 Jan 2023 01:03:36 GMT, David Holmes <dholmes@openjdk.org> wrote:
Justin King has updated the pull request incrementally with four additional commits since the last revision:
- Update copyright
Signed-off-by: Justin King <jcking@google.com> - Add missing include
Signed-off-by: Justin King <jcking@google.com> - Remove unused include
Signed-off-by: Justin King <jcking@google.com> - Reorganize tests
Signed-off-by: Justin King <jcking@google.com>
test/hotspot/gtest/utilities/test_byteswap.cpp line 2:
1: /* 2: * Copyright (c) 2022, 2023, Oracle and/or its affiliates. All rights reserved.
As a new file this should only have 2023 copyright year - thanks.
Fixed. ------------- PR: https://git.openjdk.org/jdk/pull/12114
participants (2)
-
David Holmes
-
Justin King