RFR: 8364257: JFR: User-defined events and settings with a one-letter name cannot be configured
Could I have a review of the PR that fixes a bug with short event or setting names? Instead of adding a new test, I modified an existing test so that it uses an event and setting name with one letter. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/26531/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26531&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364257 Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/26531.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26531/head:pull/26531 PR: https://git.openjdk.org/jdk/pull/26531
On Tue, 29 Jul 2025 11:43:59 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of the PR that fixes a bug with short event or setting names? Instead of adding a new test, I modified an existing test so that it uses an event and setting name with one letter.
Testing: jdk/jdk/jfr
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26531#pullrequestreview-3080185955
On Tue, 29 Jul 2025 11:43:59 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of the PR that fixes a bug with short event or setting names? Instead of adding a new test, I modified an existing test so that it uses an event and setting name with one letter.
Testing: jdk/jdk/jfr
Thanks Erik
This pull request has now been integrated. Changeset: ea7e9438 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/ea7e943874288e1cbea10a6bd82d6c7f2a1c9ae0 Stats: 10 lines in 2 files changed: 4 ins; 0 del; 6 mod 8364257: JFR: User-defined events and settings with a one-letter name cannot be configured Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/26531
participants (2)
-
Erik Gahlin
-
Markus Grönlund