RFR: 8364190: JFR: RemoteRecordingStream withers don't work
Could I please have a review of a PR that fixes the RemoteRecordingStream::with-methods? Testing: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/26540/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26540&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364190 Stats: 151 lines in 3 files changed: 143 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/26540.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26540/head:pull/26540 PR: https://git.openjdk.org/jdk/pull/26540
On Tue, 29 Jul 2025 20:59:08 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I please have a review of a PR that fixes the RemoteRecordingStream::with-methods?
Testing: test/jdk/jdk/jfr
Thanks Erik
Erik, thanks for the quick fix. Not a reviewer, but looks good (just like expected) and fixes the cases we spotted. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26540#issuecomment-3137550201
On Tue, 29 Jul 2025 20:59:08 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I please have a review of a PR that fixes the RemoteRecordingStream::with-methods?
Testing: test/jdk/jdk/jfr
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26540#pullrequestreview-3080189116
On Tue, 29 Jul 2025 20:59:08 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I please have a review of a PR that fixes the RemoteRecordingStream::with-methods?
Testing: test/jdk/jdk/jfr
Thanks Erik
This pull request has now been integrated. Changeset: da0d9598 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/da0d9598d049b17c04da95b61214b093c97fb60e Stats: 151 lines in 3 files changed: 143 ins; 0 del; 8 mod 8364190: JFR: RemoteRecordingStream withers don't work Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/26540
participants (3)
-
Dmitry Chuyko
-
Erik Gahlin
-
Markus Grönlund