Re: RFR: 8313141: Missing check for os_thread type in os_windows.cpp [v4]
os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
Julian Waters has updated the pull request incrementally with one additional commit since the last revision: Comment to explain ------------- Changes: - all: https://git.openjdk.org/jdk/pull/15079/files - new: https://git.openjdk.org/jdk/pull/15079/files/cb5d5cf8..a6350dd5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15079&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15079&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/15079.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15079/head:pull/15079 PR: https://git.openjdk.org/jdk/pull/15079
On Tue, 1 Aug 2023 06:38:47 GMT, Julian Waters <jwaters@openjdk.org> wrote:
os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
Comment to explain
Minor nit on comment but otherwise fix looks good. If there is any fallout from the change in behaviour we will deal with it then. Thanks src/hotspot/os/windows/os_windows.cpp line 721:
719: case os::asynclog_thread: 720: case os::watcher_thread: 721: default: // follow Unix and presume the unknown thread type is an internal VM one
No need for the "follow unix and". ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15079#pullrequestreview-1556480373 PR Review Comment: https://git.openjdk.org/jdk/pull/15079#discussion_r1280307240
On Tue, 1 Aug 2023 06:38:47 GMT, Julian Waters <jwaters@openjdk.org> wrote:
os::os_thread is not handled in os_windows.cpp, and therefore ignores the thread stack size option. I am unsure if this is the right way to handle os::os_thread, please let me know if it is not
Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
Comment to explain
Alright, thanks David. Waiting for other reviewers ------------- PR Comment: https://git.openjdk.org/jdk/pull/15079#issuecomment-1659880353
participants (2)
-
David Holmes
-
Julian Waters