RFR: 8332880: JFR GCHelper class recognizes "Archive" regions as valid
Hi all, please review this small change to remove "Archive" regions from the possible types of the heap region type change events. We removed Archive regions a long time ago. Testing: tier5 (containing the JFR tests afaik) Thanks, Thomas ------------- Commit messages: - 8332880 Changes: https://git.openjdk.org/jdk/pull/19390/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19390&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8332880 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/19390.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19390/head:pull/19390 PR: https://git.openjdk.org/jdk/pull/19390
On Fri, 24 May 2024 11:27:35 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
please review this small change to remove "Archive" regions from the possible types of the heap region type change events.
We removed Archive regions a long time ago.
Testing: tier5 (containing the JFR tests afaik)
Thanks, Thomas
Marked as reviewed by ayang (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19390#pullrequestreview-2076946555
On Fri, 24 May 2024 13:31:53 GMT, Albert Mingkun Yang <ayang@openjdk.org> wrote:
Hi all,
please review this small change to remove "Archive" regions from the possible types of the heap region type change events.
We removed Archive regions a long time ago.
Testing: tier5 (containing the JFR tests afaik)
Thanks, Thomas
Marked as reviewed by ayang (Reviewer).
Thanks @albertnetymk @walulyai for your reviews ------------- PR Comment: https://git.openjdk.org/jdk/pull/19390#issuecomment-2136774598
On Fri, 24 May 2024 11:27:35 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
please review this small change to remove "Archive" regions from the possible types of the heap region type change events.
We removed Archive regions a long time ago.
Testing: tier5 (containing the JFR tests afaik)
Thanks, Thomas
Marked as reviewed by iwalulya (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19390#pullrequestreview-2080566039
On Fri, 24 May 2024 11:27:35 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:
Hi all,
please review this small change to remove "Archive" regions from the possible types of the heap region type change events.
We removed Archive regions a long time ago.
Testing: tier5 (containing the JFR tests afaik)
Thanks, Thomas
This pull request has now been integrated. Changeset: 2cca83bc Author: Thomas Schatzl <tschatzl@openjdk.org> URL: https://git.openjdk.org/jdk/commit/2cca83bc82eb6b090ae96b8c072b986b93d9244a Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8332880: JFR GCHelper class recognizes "Archive" regions as valid Reviewed-by: ayang, iwalulya ------------- PR: https://git.openjdk.org/jdk/pull/19390
participants (3)
-
Albert Mingkun Yang
-
Ivan Walulya
-
Thomas Schatzl