RFR: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
Could I have a review of a test fix. Not sure why the test fails. The only way I can see is if several events get the exactly the same timestamp. Seems unlikely, but I added a loop to ensure the clock advances on every thread/core and logged the timestamp, so if it fails again, we have more information. Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/14128/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14128&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304375 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/14128.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14128/head:pull/14128 PR: https://git.openjdk.org/jdk/pull/14128
On Wed, 24 May 2023 16:30:58 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a test fix.
Not sure why the test fails. The only way I can see is if several events get the exactly the same timestamp. Seems unlikely, but I added a loop to ensure the clock advances on every thread/core and logged the timestamp, so if it fails again, we have more information.
Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/14128#pullrequestreview-1443598467
On Wed, 24 May 2023 16:30:58 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a test fix.
Not sure why the test fails. The only way I can see is if several events get the exactly the same timestamp. Seems unlikely, but I added a loop to ensure the clock advances on every thread/core and logged the timestamp, so if it fails again, we have more information.
Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java
Thanks Erik
This pull request has now been integrated. Changeset: 48702345 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/4870234552d2c63c786641493794a87654b98b7b Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false" Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/14128
participants (2)
-
Erik Gahlin
-
Markus Grönlund