Re: RFR: 8352251: Implement Cooperative JFR Sampling [v3]
Greetings,
This is the implementation of JEP [JDK-8350338 Cooperative JFR Sampling](https://bugs.openjdk.org/browse/JDK-8350338).
Implementations in this change set are provided and have been tested on the following platforms:
- windows-x64 - windows-x64-debug - linux-x64 - linux-x64-debug - macosx-x64 - macosx-x64-debug - linux-aarch64 - linux-aarch64-debug - macosx-aarch64 - macosx-aarch64-debug
Testing: tier1-6, jdk_jfr, stress testing.
Platform porters note: Some platform-specific code needs to be provided, mainly in the interpreter. Take a look at the following files for changes:
- src/hotspot/cpu/x86/frame_x86.cpp - src/hotspot/cpu/x86/interp_masm_x86.cpp - src/hotspot/cpu/x86/interp_masm_x86.hpp - src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp - src/hotspot/cpu/x86/macroAssembler_x86.cpp - src/hotspot/cpu/x86/macroAssembler_x86.hpp - src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp - src/hotspot/cpu/x86/templateTable_x86.cpp - src/hotspot/os_cpu/linux_x86/javaThread_linux_x86.hpp
Thanks Markus
Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision: - align params - adjustments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/24296/files - new: https://git.openjdk.org/jdk/pull/24296/files/7998b7c1..1015a8c1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=24296&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24296&range=01-02 Stats: 6 lines in 2 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/24296.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/24296/head:pull/24296 PR: https://git.openjdk.org/jdk/pull/24296
On Fri, 28 Mar 2025 21:24:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
This is the implementation of JEP [JDK-8350338 Cooperative JFR Sampling](https://bugs.openjdk.org/browse/JDK-8350338).
Implementations in this change set are provided and have been tested on the following platforms:
- windows-x64 - windows-x64-debug - linux-x64 - linux-x64-debug - macosx-x64 - macosx-x64-debug - linux-aarch64 - linux-aarch64-debug - macosx-aarch64 - macosx-aarch64-debug
Testing: tier1-6, jdk_jfr, stress testing.
Platform porters note: Some platform-specific code needs to be provided, mainly in the interpreter. Take a look at the following files for changes:
- src/hotspot/cpu/x86/frame_x86.cpp - src/hotspot/cpu/x86/interp_masm_x86.cpp - src/hotspot/cpu/x86/interp_masm_x86.hpp - src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp - src/hotspot/cpu/x86/macroAssembler_x86.cpp - src/hotspot/cpu/x86/macroAssembler_x86.hpp - src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp - src/hotspot/cpu/x86/templateTable_x86.cpp - src/hotspot/os_cpu/linux_x86/javaThread_linux_x86.hpp
Thanks Markus
Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
- align params - adjustments
Friendly reminder/heads-up to platform and port maintainers: Please review the necessary platform changes in advance so that your port will be ready once this integration is complete. Alternatively, you can send me your change sets for them to be incorporated into this PR. Thanks Markus ------------- PR Comment: https://git.openjdk.org/jdk/pull/24296#issuecomment-2782524969
participants (1)
-
Markus Grönlund