RFR: 8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix? ------------- Commit messages: - 8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array - 8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array Changes: https://git.openjdk.org/jdk/pull/15084/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15084&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8313394 Stats: 108 lines in 2 files changed: 107 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/15084.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15084/head:pull/15084 PR: https://git.openjdk.org/jdk/pull/15084
On Mon, 31 Jul 2023 07:20:45 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
A better fix is probably to update the description to match the implementation and change the JMC GUI to display integer min value as N/A, similar to the jfr tool and RecordedObject::toString(). There may be code that already relies on the current behavior and the min value is used to indicate N/A elsewhere. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1658320673
On Mon, 31 Jul 2023 07:20:45 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
Modifying the description is easier than the current fix. If you are comfortable with the INT_MIN value being used, I agree with your suggestion. In that case, I will only fix the description and withdraw the submitted test in this pull request. Do you know the workflow for changeing the JMC GUI? ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1662071684
On Wed, 2 Aug 2023 11:53:15 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
If you are comfortable with the INT_MIN value being used, I agree with your suggestion. In that case, I will only fix the description and withdraw the submitted test in this pull request.
Sounds good.
Do you know the workflow for changeing the JMC GUI?
There is a wiki page: https://wiki.openjdk.org/display/jmc/Main Filing a bug on JMC is probably the first step. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1662263481
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision: 8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array ------------- Changes: - all: https://git.openjdk.org/jdk/pull/15084/files - new: https://git.openjdk.org/jdk/pull/15084/files/7e584ed8..6a61e62c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=15084&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15084&range=00-01 Stats: 109 lines in 3 files changed: 0 ins; 107 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/15084.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15084/head:pull/15084 PR: https://git.openjdk.org/jdk/pull/15084
On Thu, 3 Aug 2023 09:15:58 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array
Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/15084#pullrequestreview-1560653345
On Thu, 3 Aug 2023 09:15:58 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array
You may want to change the name of the bug so it says something about the incorrect description. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1663658557
On Thu, 3 Aug 2023 09:15:58 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision:
8313394: Array Elements in OldObjectSample event should be -1 if the object is not an array
I see. I fixed the titles of the bug issue and this pull request. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1664885538
On Mon, 31 Jul 2023 07:20:45 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
Thank you for your advice. I modified the description to match the actual behavior. After integrated this fix, I will report the issue on JMC. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15084#issuecomment-1663591533
On Mon, 31 Jul 2023 07:20:45 GMT, KIRIYAMA Takuya <duke@openjdk.org> wrote:
With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array. Could anyone please review this fix?
This pull request has now been integrated. Changeset: e8c325de Author: KIRIYAMA Takuya <kiriyama.takuya@fujitsu.com> Committer: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/e8c325dea39f959ab6bb310c3913b98655e95734 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8313394: Array Elements in OldObjectSample event has the incorrect description Reviewed-by: egahlin ------------- PR: https://git.openjdk.org/jdk/pull/15084
participants (2)
-
Erik Gahlin
-
KIRIYAMA Takuya