RFR: 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id
Greetings, please help review this changeset. Details are listed in the the JIRA issue. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8276125 Changes: https://git.openjdk.java.net/jdk/pull/6702/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6702&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276125 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jdk/pull/6702.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6702/head:pull/6702 PR: https://git.openjdk.java.net/jdk/pull/6702
On Fri, 3 Dec 2021 15:46:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this changeset.
Details are listed in the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Marked as reviewed by egahlin (Reviewer). ------------- PR: https://git.openjdk.java.net/jdk/pull/6702
On Fri, 3 Dec 2021 15:46:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this changeset.
Details are listed in the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Looks fine. Probably affects all releases, right? Even before Thread-SMR, the thread oop is not really guaranteed to be here? ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6702
On Fri, 3 Dec 2021 15:46:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this changeset.
Details are listed in the JIRA issue.
Testing: jdk_jfr
Thanks Markus
"Looks fine. Probably affects all releases, right? Even before Thread-SMR, the thread oop is not really guaranteed to be here?" I don't really remember. This is old code, but the sightings started to appear in the last couple of months. Perhaps it is a combo of SMR thread lists AND the Access API coming together? The earlier API in javaClasses.inline.hpp handling null perhaps? ------------- PR: https://git.openjdk.java.net/jdk/pull/6702
On Fri, 3 Dec 2021 15:46:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this changeset.
Details are listed in the JIRA issue.
Testing: jdk_jfr
Thanks Markus
This pull request has now been integrated. Changeset: a885aab6 Author: Markus Grönlund <mgronlun@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/a885aab696777c99c8c4c5d9a46afc5fe0a4... Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8276125: RunThese24H.java SIGSEGV in JfrThreadGroup::thread_group_id Reviewed-by: egahlin, shade ------------- PR: https://git.openjdk.java.net/jdk/pull/6702
On Fri, 3 Dec 2021 15:46:15 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this changeset.
Details are listed in the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Hi, where is the `applications/runthese/RunThese24H.java`, I can't find the `runthese` sub-directory in `test/hotspot/jtreg/applications` directory. ------------- PR Comment: https://git.openjdk.org/jdk/pull/6702#issuecomment-2146854835
On Tue, 4 Jun 2024 07:55:42 GMT, SendaoYan <syan@openjdk.org> wrote:
Hi, where is the `applications/runthese/RunThese24H.java`, I can't find the `runthese` sub-directory in `test/hotspot/jtreg/applications` directory.
Unfortunately, this test is in an internal, non-public, repository. ------------- PR Comment: https://git.openjdk.org/jdk/pull/6702#issuecomment-2146977291
participants (5)
-
Aleksey Shipilev
-
Erik Gahlin
-
Markus Grönlund
-
Markus Grönlund
-
SendaoYan