Re: RFR: 8301380: jdk/jfr/api/consumer/streaming/TestCrossProcessStreaming.java [v3]
Greetings,
please help review this small adjustment to close the gap where iterated threads that attach via jni are left without a valid JFR thread id. For details, please see the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: revert uncalled for changes ------------- Changes: - all: https://git.openjdk.org/jdk/pull/12388/files - new: https://git.openjdk.org/jdk/pull/12388/files/34fc58aa..5f129b91 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12388&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12388&range=01-02 Stats: 8 lines in 1 file changed: 2 ins; 5 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/12388.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12388/head:pull/12388 PR: https://git.openjdk.org/jdk/pull/12388
On Fri, 3 Feb 2023 09:32:25 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this small adjustment to close the gap where iterated threads that attach via jni are left without a valid JFR thread id. For details, please see the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
revert uncalled for changes
Marking this not ready while details are discussed. ------------- Changes requested by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/12388
On Fri, 3 Feb 2023 09:32:25 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this small adjustment to close the gap where iterated threads that attach via jni are left without a valid JFR thread id. For details, please see the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
revert uncalled for changes
Looks good. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/12388
On Tue, 7 Feb 2023 02:10:20 GMT, David Holmes <dholmes@openjdk.org> wrote:
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
revert uncalled for changes
Looks good.
Thanks
Thanks @dholmes-ora, for the review! ------------- PR: https://git.openjdk.org/jdk/pull/12388
On Fri, 3 Feb 2023 09:32:25 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
please help review this small adjustment to close the gap where iterated threads that attach via jni are left without a valid JFR thread id. For details, please see the JIRA issue.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
revert uncalled for changes
Marked as reviewed by egahlin (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/12388
participants (3)
-
David Holmes
-
Erik Gahlin
-
Markus Grönlund