RFR: 8364461: JFR: Default constructor may not be first in setting control
Could I have a review of a PR that fixes a bug occurring when a user-defined setting does not have the default constructor first? Test: test/jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Initial Changes: https://git.openjdk.org/jdk/pull/26582/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26582&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8364461 Stats: 28 lines in 2 files changed: 20 ins; 7 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/26582.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26582/head:pull/26582 PR: https://git.openjdk.org/jdk/pull/26582
On Thu, 31 Jul 2025 19:24:46 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that fixes a bug occurring when a user-defined setting does not have the default constructor first?
Test: test/jdk/jdk/jfr
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26582#pullrequestreview-3080184915
On Thu, 31 Jul 2025 19:24:46 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that fixes a bug occurring when a user-defined setting does not have the default constructor first?
Test: test/jdk/jdk/jfr
Thanks Erik
This pull request has now been integrated. Changeset: b96b9c3d Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/b96b9c3d5b2ffaeaa365b2f0d33674a980c96547 Stats: 28 lines in 2 files changed: 20 ins; 7 del; 1 mod 8364461: JFR: Default constructor may not be first in setting control Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/26582
participants (2)
-
Erik Gahlin
-
Markus Grönlund