RFR: 8338938: The result of the combine method of SettingsControl is not used
Could you please review this PR that SettingsControl does not work properly when configured with multiple records. Regards, Chihiro ------------- Commit messages: - Fixed to use the return value of the combine method of SettingsControl Changes: https://git.openjdk.org/jdk/pull/20707/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20707&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338938 Stats: 31 lines in 2 files changed: 29 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/20707.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/20707/head:pull/20707 PR: https://git.openjdk.org/jdk/pull/20707
On Sun, 25 Aug 2024 15:14:39 GMT, Chihiro Ito <cito@openjdk.org> wrote:
Could you please review this PR that SettingsControl does not work properly when configured with multiple records.
Regards, Chihiro
Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/20707#pullrequestreview-2261044198
On Sun, 25 Aug 2024 15:14:39 GMT, Chihiro Ito <cito@openjdk.org> wrote:
Could you please review this PR that SettingsControl does not work properly when configured with multiple records.
Regards, Chihiro
This pull request has now been integrated. Changeset: 78f53efc Author: Chihiro Ito <cito@openjdk.org> URL: https://git.openjdk.org/jdk/commit/78f53efcd6a886375fac3fad69f428ecc852fcd6 Stats: 31 lines in 2 files changed: 29 ins; 0 del; 2 mod 8338938: The result of the combine method of SettingsControl is not used Reviewed-by: egahlin ------------- PR: https://git.openjdk.org/jdk/pull/20707
participants (2)
-
Chihiro Ito
-
Erik Gahlin