RFR: JDK-8298035: Provide better descriptions for JIT compiler JFR events
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler We should add some helpful description texts for these JFR events. ------------- Commit messages: - JDK-8298035 Changes: https://git.openjdk.org/jdk/pull/11506/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8298035 Stats: 59 lines in 2 files changed: 50 ins; 0 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/11506.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11506/head:pull/11506 PR: https://git.openjdk.org/jdk/pull/11506
On Mon, 5 Dec 2022 09:11:15 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
When it comes to descriptions, we have tried to avoid using the word 'event' and instead describe what the event represents. We have also tried to not add descriptions, to both fields or events, if a label makes it obvious. ------------- PR: https://git.openjdk.org/jdk/pull/11506
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove strange file, maybe it comes from the OpenJDK build ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11506/files - new: https://git.openjdk.org/jdk/pull/11506/files/74c0f36f..46f5aa65 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=00-01 Stats: 32 lines in 1 file changed: 0 ins; 32 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11506.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11506/head:pull/11506 PR: https://git.openjdk.org/jdk/pull/11506
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: Change some descriptions ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11506/files - new: https://git.openjdk.org/jdk/pull/11506/files/46f5aa65..03afa379 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=01-02 Stats: 8 lines in 1 file changed: 0 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/11506.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11506/head:pull/11506 PR: https://git.openjdk.org/jdk/pull/11506
On Tue, 6 Dec 2022 14:51:29 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
Change some descriptions
Hi Erik, I removed 2 of the description texts and adjusted a few more to avoid 'event' . ------------- PR: https://git.openjdk.org/jdk/pull/11506
On Tue, 6 Dec 2022 14:51:29 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
Change some descriptions
Marked as reviewed by clanger (Reviewer). ------------- PR: https://git.openjdk.org/jdk/pull/11506
On Tue, 6 Dec 2022 14:51:29 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
Change some descriptions
src/hotspot/share/jfr/metadata/metadata.xml line 598:
596: 597: <Event name="CompilationFailure" category="Java Virtual Machine, Compiler" label="Compilation Failure" 598: description="In case a JIT compilation failed, a CompilationFailure is triggered, reporting the reason"
It would be better to use "compilation failure" instead of the event name (CompilationFailure) here. ------------- PR: https://git.openjdk.org/jdk/pull/11506
On Tue, 6 Dec 2022 21:06:02 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
Change some descriptions
src/hotspot/share/jfr/metadata/metadata.xml line 598:
596: 597: <Event name="CompilationFailure" category="Java Virtual Machine, Compiler" label="Compilation Failure" 598: description="In case a JIT compilation failed, a CompilationFailure is triggered, reporting the reason"
It would be better to use "compilation failure" instead of the event name (CompilationFailure) here.
Hi Erik, I adjusted the description. ------------- PR: https://git.openjdk.org/jdk/pull/11506
On Tue, 6 Dec 2022 14:51:29 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
Change some descriptions
+1 ------------- Marked as reviewed by stuefe (Reviewer). PR: https://git.openjdk.org/jdk/pull/11506
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: adjust description of CompilationFailure ------------- Changes: - all: https://git.openjdk.org/jdk/pull/11506/files - new: https://git.openjdk.org/jdk/pull/11506/files/03afa379..ee15dd38 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11506&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11506.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11506/head:pull/11506 PR: https://git.openjdk.org/jdk/pull/11506
On Wed, 7 Dec 2022 08:12:23 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
adjust description of CompilationFailure
Thanks for the reviews ! ------------- PR: https://git.openjdk.org/jdk/pull/11506
On Mon, 5 Dec 2022 09:11:15 GMT, Matthias Baesken <mbaesken@openjdk.org> wrote:
Most Compiler related JFR events lack descriptions, see https://sap.github.io/SapMachine/jfrevents/20.html#jvm-compiler
We should add some helpful description texts for these JFR events.
This pull request has now been integrated. Changeset: 58170f65 Author: Matthias Baesken <mbaesken@openjdk.org> URL: https://git.openjdk.org/jdk/commit/58170f657c2ccc7afd1e9056d7630a3b564207ef Stats: 21 lines in 1 file changed: 14 ins; 0 del; 7 mod 8298035: Provide better descriptions for JIT compiler JFR events Reviewed-by: clanger, stuefe ------------- PR: https://git.openjdk.org/jdk/pull/11506
participants (4)
-
Christoph Langer
-
Erik Gahlin
-
Matthias Baesken
-
Thomas Stuefe