RFR: 8322489 : 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC
Greetings, A footprint regression was accidentally introduced with [JDK-8211238](https://bugs.openjdk.org/browse/JDK-8211238). A small part of the JFR system had to be initialized early to support the functionality. We later decided that we only support this functionality iff the system is started with -XX:StartFlightRecording on the command-line. This PR will adjust to only perform early initialization under this premise. Testing: jdk_jfr Thanks Markus ------------- Commit messages: - 8322489 Changes: https://git.openjdk.org/jdk/pull/17179/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17179&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322489 Stats: 47 lines in 5 files changed: 29 ins; 9 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/17179.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17179/head:pull/17179 PR: https://git.openjdk.org/jdk/pull/17179
On Thu, 21 Dec 2023 20:11:42 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
A footprint regression was accidentally introduced with [JDK-8211238](https://bugs.openjdk.org/browse/JDK-8211238).
A small part of the JFR system had to be initialized early to support the functionality. We later decided that we only support this functionality iff the system is started with -XX:StartFlightRecording on the command-line.
This PR will adjust to only perform early initialization under this premise.
Testing: jdk_jfr
Thanks Markus
Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/17179#pullrequestreview-1793687339
Greetings,
A footprint regression was accidentally introduced with [JDK-8211238](https://bugs.openjdk.org/browse/JDK-8211238).
A small part of the JFR system had to be initialized early to support the functionality. We later decided that we only support this functionality iff the system is started with -XX:StartFlightRecording on the command-line.
This PR will adjust to only perform early initialization under this premise.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision: adjustment ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17179/files - new: https://git.openjdk.org/jdk/pull/17179/files/48b42591..ac6f6928 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17179&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17179&range=00-01 Stats: 18 lines in 2 files changed: 8 ins; 9 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17179.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17179/head:pull/17179 PR: https://git.openjdk.org/jdk/pull/17179
Greetings,
A footprint regression was accidentally introduced with [JDK-8211238](https://bugs.openjdk.org/browse/JDK-8211238).
A small part of the JFR system had to be initialized early to support the functionality. We later decided that we only support this functionality iff the system is started with -XX:StartFlightRecording on the command-line.
This PR will adjust to only perform early initialization under this premise.
Testing: jdk_jfr
Thanks Markus
Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision: - Merge branch '8322489' of github.com:mgronlun/jdk into 8322489 - adjustment ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17179/files - new: https://git.openjdk.org/jdk/pull/17179/files/ac6f6928..2f8439ab Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17179&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17179&range=01-02 Stats: 8 lines in 1 file changed: 2 ins; 5 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17179.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17179/head:pull/17179 PR: https://git.openjdk.org/jdk/pull/17179
On Thu, 21 Dec 2023 20:11:42 GMT, Markus Grönlund <mgronlun@openjdk.org> wrote:
Greetings,
A footprint regression was accidentally introduced with [JDK-8211238](https://bugs.openjdk.org/browse/JDK-8211238).
A small part of the JFR system had to be initialized early to support the functionality. We later decided that we only support this functionality iff the system is started with -XX:StartFlightRecording on the command-line.
This PR will adjust to only perform early initialization under this premise.
Testing: jdk_jfr
Thanks Markus
This pull request has now been integrated. Changeset: 09c6c4ff Author: Markus Grönlund <mgronlun@openjdk.org> URL: https://git.openjdk.org/jdk/commit/09c6c4ff021b7dc719c0b1e0dfb041b03bba1b5d Stats: 32 lines in 6 files changed: 19 ins; 3 del; 10 mod 8322489: 22-b27: Up to 7% regression in all Footprint3-*-G1/ZGC Reviewed-by: egahlin ------------- PR: https://git.openjdk.org/jdk/pull/17179
participants (2)
-
Erik Gahlin
-
Markus Grönlund