Re: RFR: 8347463: jdk/jfr/threading/TestManyVirtualThreads.java crashes with assert(oopDesc::is_oop_or_null(val)) [v11]
This PR introduces a fix for a intermittent assert crash due to a non-oop found in the stack when deoptimizing.
The `inline_native_GetEventWriter` JFR intrinsic performs a call into the runtime, which can safepoint, to write a checkpoint for the vthread. This call returns a global handle (`jobject`) that then gets resolved to a raw oop.
However, the corresponding `jfr_write_checkpoint_Type` does not set any return, modelling the call as `void`. If a safepoint hits in the small window after the stub returns but before the writer oop is used, and the GC moves the object in that window, the deoptimization path cannot resolve a handle that it never recorded, leading to the subsequent crash.
An IR Framework test is introduced to exercise the error explicitly. Additionally, related documentation in form of comments in the appropriate file (`runtime.hpp`) is added to hopefully prevent similar cases in the future.
**Testing:** passes tiers 1-5
Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision: Rename class ------------- Changes: - all: https://git.openjdk.org/jdk/pull/27913/files - new: https://git.openjdk.org/jdk/pull/27913/files/1f922569..80f572a2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=27913&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27913&range=09-10 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/27913.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/27913/head:pull/27913 PR: https://git.openjdk.org/jdk/pull/27913
On Tue, 28 Oct 2025 09:39:05 GMT, Anton Seoane Ampudia <aseoane@openjdk.org> wrote:
This PR introduces a fix for a intermittent assert crash due to a non-oop found in the stack when deoptimizing.
The `inline_native_GetEventWriter` JFR intrinsic performs a call into the runtime, which can safepoint, to write a checkpoint for the vthread. This call returns a global handle (`jobject`) that then gets resolved to a raw oop.
However, the corresponding `jfr_write_checkpoint_Type` does not set any return, modelling the call as `void`. If a safepoint hits in the small window after the stub returns but before the writer oop is used, and the GC moves the object in that window, the deoptimization path cannot resolve a handle that it never recorded, leading to the subsequent crash.
An IR Framework test is introduced to exercise the error explicitly. Additionally, related documentation in form of comments in the appropriate file (`runtime.hpp`) is added to hopefully prevent similar cases in the future.
**Testing:** passes tiers 1-5
Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
Rename class
test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java line 38:
36: * @requires vm.hasJFR 37: * @library /test/lib / 38: * @run driver compiler.intrinsics.TestReturnsOopSetForJFRWriteCheckpoint
You will have to update this line as well after the class name change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2468766731
On Tue, 28 Oct 2025 09:43:30 GMT, Roberto Castañeda Lozano <rcastanedalo@openjdk.org> wrote:
Anton Seoane Ampudia has updated the pull request incrementally with one additional commit since the last revision:
Rename class
test/hotspot/jtreg/compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java line 38:
36: * @requires vm.hasJFR 37: * @library /test/lib / 38: * @run driver compiler.intrinsics.TestReturnsOopSetForJFRWriteCheckpoint
You will have to update this line as well after the class name change.
Oh, right. My bad. Fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27913#discussion_r2468774982
participants (2)
-
Anton Seoane Ampudia
-
Roberto Castañeda Lozano