RFR: 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java
Could I have a review of a PR that improves logging of a test to be able to debug failures more easily. Fixes: Timestamps for all events are written with nanosecond precision Tests no longer abort before all events have been processed. Fixed typo of the word ordered Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java Thanks ------------- Commit messages: - Print all timestamps - Initial Changes: https://git.openjdk.org/jdk/pull/18961/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18961&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8331153 Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/18961.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18961/head:pull/18961 PR: https://git.openjdk.org/jdk/pull/18961
On Thu, 25 Apr 2024 19:09:33 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that improves logging of a test to be able to debug failures more easily.
Fixes: Timestamps for all events are written with nanosecond precision Tests no longer abort before all events have been processed. Fixed typo of the word ordered
Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java
Thanks
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/18961#pullrequestreview-2025638240
On Thu, 25 Apr 2024 19:09:33 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that improves logging of a test to be able to debug failures more easily.
Fixes: Timestamps for all events are written with nanosecond precision Tests no longer abort before all events have been processed. Fixed typo of the word ordered
Testing: jdk/jfr/api/consumer/filestream/TestOrdered.java
Thanks
This pull request has now been integrated. Changeset: f3bb3e21 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/f3bb3e21704dd47c6c5d5753ca5882520a538c06 Stats: 21 lines in 1 file changed: 15 ins; 1 del; 5 mod 8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/18961
participants (2)
-
Erik Gahlin
-
Markus Grönlund