RFR: 8303229: JFR: Preserve disk repository after exit
Hi, Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit. Testing: jdk/jdk/jfr Thanks Erik ------------- Commit messages: - Fix whitespace - Initial - Initial Changes: https://git.openjdk.org/jdk/pull/13111/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303229 Stats: 198 lines in 8 files changed: 157 ins; 1 del; 40 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
On Tue, 21 Mar 2023 01:24:44 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
@egahlin you to update this with latest master to get DCmd `num_arguments` changes that went in recently. Also I would expect to see an update to the JFR manpage for this. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13111#issuecomment-1477179215 PR Comment: https://git.openjdk.org/jdk/pull/13111#issuecomment-1477180620
On Tue, 21 Mar 2023 02:02:59 GMT, David Holmes <dholmes@openjdk.org> wrote:
@egahlin you to update this with latest master to get DCmd `num_arguments` changes that went in recently.
Will fix. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13111#issuecomment-1477183338
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Increase parameter count - Merge branch 'master' of https://github.com/openjdk/jdk into keeponexit - Fix whitespace - Initial - Initial ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/47d9b4d2..9e8094d2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=00-01 Stats: 171208 lines in 2375 files changed: 121845 ins; 28700 del; 20663 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
On Wed, 22 Mar 2023 16:21:51 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
- Increase parameter count - Merge branch 'master' of https://github.com/openjdk/jdk into keeponexit - Fix whitespace - Initial - Initial
Seems okay to me. Can't comment on the actual functionality. Thanks. test/jdk/jdk/jfr/jcmd/TestJcmdPreserveRepository.java line 2:
1: /* 2: * Copyright (c) 2015, 2018, Oracle and/or its affiliates. All rights reserved.
New file should have new copyright - unless substantially copied (IIUC). ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13111#pullrequestreview-1353711980 PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1145581349
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Docs update ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/9e8094d2..0b500c8e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=01-02 Stats: 12 lines in 2 files changed: 12 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
On Thu, 23 Mar 2023 12:41:29 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Docs update
src/java.base/share/man/java.1 line 1344:
1342: after the JVM has exited. 1343: If false, files are deleted. 1344: By default, this parameters is disabled.
Do you mean by default it is false? Typo: parameters -> parameter ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1146135729
On Thu, 23 Mar 2023 12:45:42 GMT, David Holmes <dholmes@openjdk.org> wrote:
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Docs update
src/java.base/share/man/java.1 line 1344:
1342: after the JVM has exited. 1343: If false, files are deleted. 1344: By default, this parameters is disabled.
Do you mean by default it is false?
Typo: parameters -> parameter
It is false by default. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1146217088
On Thu, 23 Mar 2023 13:41:05 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
src/java.base/share/man/java.1 line 1344:
1342: after the JVM has exited. 1343: If false, files are deleted. 1344: By default, this parameters is disabled.
Do you mean by default it is false?
Typo: parameters -> parameter
It is false by default.
(I used similar wording as for the retransform parameter "By default, this parameter is enabled".)
Seems an awkward mix of terminology to me. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1146923457
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Fix copyright ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/0b500c8e..6c860c1e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=02-03 Stats: 23 lines in 2 files changed: 22 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Typo ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/6c860c1e..2665c785 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
On Thu, 23 Mar 2023 13:49:42 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Typo
src/jdk.jcmd/share/man/jcmd.1 line 409:
407: after the JVM has exited. 408: If false, files are deleted. 409: By default, this parameters is disabled.
This still has "parameters" typo. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1146926863
On Thu, 23 Mar 2023 13:49:42 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Typo
test/jdk/jdk/jfr/startupargs/TestPreserveRepository.java line 43:
41: 42: public static void main(String... args) throws Exception { 43: Path path = Path.of("./preserved");
nit Suggestion: Path path = Path.of("./preserved"); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1148937113
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Update description and allow initialization after JFR has started ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/2665c785..c744b1c7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=04-05 Stats: 9 lines in 3 files changed: 3 ins; 3 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Typo ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/c744b1c7..807d62b7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=05-06 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Fix descriptions ------------- Changes: - all: https://git.openjdk.org/jdk/pull/13111/files - new: https://git.openjdk.org/jdk/pull/13111/files/807d62b7..5a914ea7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13111&range=06-07 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk/pull/13111.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13111/head:pull/13111 PR: https://git.openjdk.org/jdk/pull/13111
On Fri, 31 Mar 2023 18:56:20 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Fix descriptions
Looks good. ------------- Marked as reviewed by mgronlun (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13111#pullrequestreview-1367450724
On Fri, 31 Mar 2023 18:56:20 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Fix descriptions
Marked as reviewed by dholmes (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/13111#pullrequestreview-1368152309
On Tue, 21 Mar 2023 01:24:44 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Hi,
Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
Testing: jdk/jdk/jfr
Thanks Erik
This pull request has now been integrated. Changeset: 336a23e7 Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/336a23e70a9624c124137ee245fa33784d1e824b Stats: 236 lines in 10 files changed: 191 ins; 1 del; 44 mod 8303229: JFR: Preserve disk repository after exit Reviewed-by: dholmes, mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/13111
participants (4)
-
Andrey Turbanov
-
David Holmes
-
Erik Gahlin
-
Markus Grönlund