RFR: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
Could I have a review of a PR that fixes an intermittent failure. I have not been able to reproduce the failure after running the test 10 000 times, but it does reproduce quite easily without the fix. It could be that the method awaitUniqueTimestamp() could be removed completely with the introduction of a similar method in https://github.com/openjdk/jdk/pull/19799 (which happens before the chunk rotation), but I rather fix it separately. I want this change to be suitable for a backport to JDK 23 and without additional regressions. Thanks Erik ------------- Commit messages: - Remove accidentally added file - Initial Changes: https://git.openjdk.org/jdk/pull/19892/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19892&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334886 Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/19892.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19892/head:pull/19892 PR: https://git.openjdk.org/jdk/pull/19892
On Tue, 25 Jun 2024 23:45:24 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that fixes an intermittent failure. I have not been able to reproduce the failure after running the test 10 000 times, but it does reproduce quite easily without the fix.
It could be that the method awaitUniqueTimestamp() could also be removed with the introduction of a similar method in https://github.com/openjdk/jdk/pull/19799 (which happens before the chunk rotation), but I rather fix it separately.
I want this change to be suitable for a backport to JDK 23 without additional regressions.
Thanks Erik
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/19892#pullrequestreview-2145770227
On Tue, 25 Jun 2024 23:45:24 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of a PR that fixes an intermittent failure. I have not been able to reproduce the failure after running the test 10 000 times, but it does reproduce quite easily without the fix.
It could be that the method awaitUniqueTimestamp() could also be removed with the introduction of a similar method in https://github.com/openjdk/jdk/pull/19799 (which happens before the chunk rotation), but I rather fix it separately.
I want this change to be suitable for a backport to JDK 23 without additional regressions.
Thanks Erik
This pull request has now been integrated. Changeset: 0e6b0cba Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/0e6b0cbaaa0d5272f60ee4fe09cf5e247e68c2a8 Stats: 3 lines in 2 files changed: 0 ins; 3 del; 0 mod 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/19892
participants (2)
-
Erik Gahlin
-
Markus Grönlund